Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature-16608][Doc] Add Security Model for DS #16609

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

wangxj3
Copy link
Contributor

@wangxj3 wangxj3 commented Sep 11, 2024

Purpose of the pull request

close #16608

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@SbloodyS SbloodyS changed the title [Feature-16608]add Security Model [Feature-16608] Add Security Model Sep 12, 2024
@SbloodyS SbloodyS changed the title [Feature-16608] Add Security Model [Feature-16608][Doc] Add Security Model Sep 12, 2024
davidzollo
davidzollo previously approved these changes Sep 15, 2024
Copy link
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Great job
This is a very good beginning. We can gradually improve this security model and more suggestions are welcome.

@davidzollo davidzollo added this to the 3.3.0 milestone Sep 15, 2024
@davidzollo
Copy link
Contributor

davidzollo commented Sep 15, 2024

By the way, please add a note in this following doc, the reporter should read our security model before submitting the security issues https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/security.md

@wangxj3
Copy link
Contributor Author

wangxj3 commented Sep 18, 2024

By the way, please add a note in this following doc, the reporter should read our security model before submitting the security issues https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/security.md

ok

…y-doc

# Conflicts:
#	docs/configs/docsdev.js
@@ -0,0 +1,86 @@
# Apache DolphinScheduler Security Model
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be in the same directory as security.md.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security.md is the part of guide - security.
图片

Suggested change
# Apache DolphinScheduler Security Model
# Apache DolphinScheduler Security Model

Is it inappropriate to put it here ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The security.md is not reflected in the document, which is a bug. I've create issue #16690 to fix it.

@SbloodyS SbloodyS added the feature new feature label Oct 11, 2024
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@SbloodyS SbloodyS merged commit 83e6a8c into apache:dev Oct 16, 2024
34 checks passed
@SbloodyS SbloodyS changed the title [Feature-16608][Doc] Add Security Model [Feature-16608][Doc] Add Security Model for DS Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Security Model
3 participants