-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix-16338][Test] Fix Master integration test case has been skipped in ci #16637
Merged
ruanwenjun
merged 1 commit into
apache:dev
from
ruanwenjun:dev_wenjun_hotFixMasterTestCase
Sep 21, 2024
Merged
[Fix-16338][Test] Fix Master integration test case has been skipped in ci #16637
ruanwenjun
merged 1 commit into
apache:dev
from
ruanwenjun:dev_wenjun_hotFixMasterTestCase
Sep 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
requested review from
Gallardot,
caishunfeng and
SbloodyS
as code owners
September 20, 2024 12:40
ruanwenjun
force-pushed
the
dev_wenjun_hotFixMasterTestCase
branch
from
September 20, 2024 12:43
94f8064
to
69baaa3
Compare
ruanwenjun
changed the title
[Hotfix] Fix Master integration test case has been passed in ci
[Fix-16338][Hotfix] Fix Master integration test case has been skipped in ci
Sep 20, 2024
ruanwenjun
force-pushed
the
dev_wenjun_hotFixMasterTestCase
branch
from
September 20, 2024 12:44
69baaa3
to
c9b19ac
Compare
ruanwenjun
force-pushed
the
dev_wenjun_hotFixMasterTestCase
branch
2 times, most recently
from
September 20, 2024 14:22
e6d651f
to
8718ae5
Compare
ruanwenjun
force-pushed
the
dev_wenjun_hotFixMasterTestCase
branch
from
September 20, 2024 14:48
8718ae5
to
c37c2fe
Compare
ruanwenjun
force-pushed
the
dev_wenjun_hotFixMasterTestCase
branch
3 times, most recently
from
September 20, 2024 16:05
dc07fb6
to
17be98d
Compare
SbloodyS
previously approved these changes
Sep 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ruanwenjun
force-pushed
the
dev_wenjun_hotFixMasterTestCase
branch
3 times, most recently
from
September 21, 2024 04:03
e361387
to
0c0140a
Compare
ruanwenjun
changed the title
[Fix-16338][Hotfix] Fix Master integration test case has been skipped in ci
[Fix-16338][UT] Fix Master integration test case has been skipped in ci
Sep 21, 2024
ruanwenjun
changed the title
[Fix-16338][UT] Fix Master integration test case has been skipped in ci
[Fix-16338][Test] Fix Master integration test case has been skipped in ci
Sep 21, 2024
SbloodyS
approved these changes
Sep 21, 2024
caishunfeng
approved these changes
Sep 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ruanwenjun
force-pushed
the
dev_wenjun_hotFixMasterTestCase
branch
from
September 21, 2024 06:38
0c0140a
to
39bc3c2
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #16638
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md