[fix](json-quote) fix json quote func for not find the func (#42005)

pick #39931
apache · Oct 17, 2024 · 59d3326 · 59d3326
1 parent 633f531
commit 59d3326
Show file tree

Hide file tree

Showing 3 changed files with 72 additions and 2 deletions.
diff --git a/be/src/vec/functions/function_json.cpp b/be/src/vec/functions/function_json.cpp
@@ -802,6 +802,12 @@ class FunctionJsonAlwaysNotNullable : public IFunction {
 struct FunctionJsonQuoteImpl {
     static constexpr auto name = "json_quote";
 
+    static DataTypePtr get_return_type_impl(const DataTypes& arguments) {
+        if (!arguments.empty() && arguments[0] && arguments[0]->is_nullable()) {
+            return make_nullable(std::make_shared<DataTypeString>());
+        }
+        return std::make_shared<DataTypeString>();
+    }
     static void execute(const std::vector<const ColumnString*>& data_columns,
                         ColumnString& result_column, size_t input_rows_count) {
         rapidjson::Document document;
@@ -810,13 +816,13 @@ struct FunctionJsonQuoteImpl {
         rapidjson::Value value;
 
         rapidjson::StringBuffer buf;
-        rapidjson::Writer<rapidjson::StringBuffer> writer(buf);
 
         for (int i = 0; i < input_rows_count; i++) {
             StringRef data = data_columns[0]->get_data_at(i);
             value.SetString(data.data, data.size, allocator);
 
             buf.Clear();
+            rapidjson::Writer<rapidjson::StringBuffer> writer(buf);
             value.Accept(writer);
             result_column.insert_data(buf.GetString(), buf.GetSize());
         }
@@ -893,7 +899,7 @@ class FunctionJson : public IFunction {
     bool is_variadic() const override { return true; }
 
     DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
-        return std::make_shared<DataTypeString>();
+        return Impl::get_return_type_impl(arguments);
     }
 
     Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,