Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[branch-2.0] Picks "[Fix](partial update) Fix __DORIS_SEQUENCE_COL__ is not set for newly inserted rows in partial update #40272" #40966

Open
wants to merge 4 commits into
base: branch-2.0
Choose a base branch
from
Open

[branch-2.0] Picks "[Fix](partial update) Fix __DORIS_SEQUENCE_COL__ is not set for newly inserted rows in partial update #40272" #40966

wants to merge 4 commits into from

Conversation

bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Sep 19, 2024

picks #40272

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@bobhan1 bobhan1 mentioned this pull request Sep 19, 2024
Merged
@bobhan1
Copy link
Contributor Author

bobhan1 commented Sep 19, 2024

run buildall

github-actions[bot]
github-actions bot reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/exec/tablet_info.h
@@ -90,6 +90,8 @@ class OlapTableSchemaParam {
}
void set_timestamp_ms(int64_t timestamp_ms) { _timestamp_ms = timestamp_ms; }
int64_t timestamp_ms() const { return _timestamp_ms; }
void set_nano_seconds(int32_t nano_seconds) { _nano_seconds = nano_seconds; }
int32_t nano_seconds() const { return _nano_seconds; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: function 'nano_seconds' should be marked [[nodiscard]] [modernize-use-nodiscard]

Suggested change
int32_t nano_seconds() const { return _nano_seconds; }
[[nodiscard]] int32_t nano_seconds() const { return _nano_seconds; }

@bobhan1
Copy link
Contributor Author

bobhan1 commented Sep 19, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.83% (8140/21515)
Line Coverage: 29.58% (66983/226431)
Region Coverage: 29.06% (34553/118889)
Branch Coverage: 24.97% (17800/71294)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a80398be224f9698e4062ab08a6a25912c7f3d97_a80398be224f9698e4062ab08a6a25912c7f3d97/report/index.html

@bobhan1
Copy link
Contributor Author

bobhan1 commented Sep 19, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 48877 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 95e593a59dbb14415e83a152fe7bb7fd5688fcb6, data reload: false

------ Round 1 ----------------------------------
q1	18169	4418	4332	4332
q2	2037	149	146	146
q3	10435	1869	1872	1869
q4	10335	1270	1318	1270
q5	8882	3905	3925	3905
q6	228	145	125	125
q7	2013	1581	1599	1581
q8	9297	2719	2691	2691
q9	10221	9873	9689	9689
q10	8607	3509	3467	3467
q11	418	250	254	250
q12	472	296	301	296
q13	18357	3995	4044	3995
q14	348	331	333	331
q15	511	455	464	455
q16	542	455	455	455
q17	1133	976	953	953
q18	7257	6958	6858	6858
q19	1685	1499	1433	1433
q20	505	312	293	293
q21	4331	4151	4089	4089
q22	501	397	394	394
Total cold run time: 116284 ms
Total hot run time: 48877 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4361	4334	4282	4282
q2	324	227	218	218
q3	4137	4156	4119	4119
q4	2754	2749	2750	2749
q5	7148	7105	7144	7105
q6	242	121	121	121
q7	3227	2831	2843	2831
q8	4372	4468	4483	4468
q9	13660	13557	13564	13557
q10	4240	4257	4270	4257
q11	772	680	677	677
q12	1017	867	857	857
q13	6799	3751	3757	3751
q14	454	421	429	421
q15	501	453	461	453
q16	635	622	588	588
q17	3796	3847	3889	3847
q18	8918	8801	8926	8801
q19	1752	1666	1652	1652
q20	2415	2139	2126	2126
q21	8590	8463	8601	8463
q22	1028	980	968	968
Total cold run time: 81142 ms
Total hot run time: 76311 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.85% (8144/21515)
Line Coverage: 29.60% (67032/226431)
Region Coverage: 29.09% (34585/118889)
Branch Coverage: 25.00% (17820/71294)
Coverage Report: http://coverage.selectdb-in.cc/coverage/95e593a59dbb14415e83a152fe7bb7fd5688fcb6_95e593a59dbb14415e83a152fe7bb7fd5688fcb6/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 213092 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 95e593a59dbb14415e83a152fe7bb7fd5688fcb6, data reload: false

query1	928	392	439	392
query2	6745	2303	1905	1905
query3	6988	213	216	213
query4	23947	22005	21925	21925
query5	20371	6626	6604	6604
query6	424	221	227	221
query7	5275	303	315	303
query8	249	275	259	259
query9	3079	2639	2581	2581
query10	487	300	307	300
query11	15915	14909	14805	14805
query12	124	75	72	72
query13	1009	438	440	438
query14	19115	13297	13460	13297
query15	361	219	222	219
query16	6441	281	260	260
query17	1567	918	938	918
query18	889	318	321	318
query19	223	155	147	147
query20	82	78	81	78
query21	191	94	101	94
query22	4966	5053	4966	4966
query23	34111	33386	33535	33386
query24	6581	6295	6315	6295
query25	532	450	447	447
query26	796	168	161	161
query27	2269	294	288	288
query28	6076	2247	2217	2217
query29	2877	2696	2857	2696
query30	244	166	166	166
query31	980	734	729	729
query32	72	65	61	61
query33	428	249	253	249
query34	864	467	475	467
query35	1109	912	905	905
query36	1218	1269	1099	1099
query37	94	62	61	61
query38	3032	2880	2949	2880
query39	1388	1334	1337	1334
query40	212	93	93	93
query41	39	37	36	36
query42	87	83	84	83
query43	681	612	611	611
query44	1197	724	720	720
query45	245	233	231	231
query46	1236	979	964	964
query47	1945	1858	1594	1594
query48	513	413	407	407
query49	612	381	373	373
query50	871	624	626	624
query51	4752	4756	4695	4695
query52	92	79	68	68
query53	231	192	192	192
query54	2661	2465	2506	2465
query55	82	83	86	83
query56	235	194	196	194
query57	1177	1098	1091	1091
query58	217	193	214	193
query59	3799	3275	3229	3229
query60	223	193	187	187
query61	95	94	93	93
query62	806	452	474	452
query63	204	176	175	175
query64	3354	1556	1496	1496
query65	3650	3544	3543	3543
query66	729	431	415	415
query67	16131	15540	16629	15540
query68	8691	646	648	646
query69	498	278	260	260
query70	1587	1366	1467	1366
query71	427	316	317	316
query72	6871	4886	4809	4809
query73	747	311	320	311
query74	6279	5820	5793	5793
query75	4688	3704	3594	3594
query76	4547	1134	1219	1134
query77	554	262	253	253
query78	12532	15975	12261	12261
query79	6033	622	659	622
query80	1644	396	379	379
query81	515	243	239	239
query82	269	96	97	96
query83	171	139	136	136
query84	259	71	69	69
query85	734	314	321	314
query86	360	326	291	291
query87	3205	3067	2967	2967
query88	3990	2378	2372	2372
query89	375	297	283	283
query90	1876	211	213	211
query91	153	138	148	138
query92	57	51	51	51
query93	2251	563	553	553
query94	958	208	206	206
query95	2110	2068	1975	1975
query96	632	353	338	338
query97	6433	6429	6489	6429
query98	226	200	215	200
query99	2556	877	898	877
Total cold run time: 310351 ms
Total hot run time: 213092 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.23 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 95e593a59dbb14415e83a152fe7bb7fd5688fcb6, data reload: false

query1	0.03	0.02	0.02
query2	0.07	0.03	0.03
query3	0.25	0.06	0.05
query4	1.79	0.06	0.08
query5	0.52	0.52	0.52
query6	1.23	0.60	0.61
query7	0.02	0.01	0.01
query8	0.04	0.03	0.02
query9	0.55	0.47	0.48
query10	0.53	0.52	0.54
query11	0.12	0.08	0.08
query12	0.11	0.10	0.10
query13	0.62	0.62	0.62
query14	0.78	0.80	0.81
query15	0.77	0.76	0.75
query16	0.37	0.39	0.37
query17	0.98	1.01	1.01
query18	0.22	0.25	0.23
query19	1.92	1.84	1.81
query20	0.01	0.01	0.02
query21	15.48	0.56	0.58
query22	2.13	2.26	1.88
query23	17.12	0.97	1.12
query24	5.13	1.10	1.22
query25	0.39	0.06	0.05
query26	0.64	0.16	0.16
query27	0.05	0.03	0.04
query28	7.68	0.75	0.71
query29	12.78	2.38	2.35
query30	0.59	0.54	0.49
query31	2.81	0.39	0.38
query32	3.38	0.50	0.50
query33	3.11	3.08	3.05
query34	15.26	4.80	4.80
query35	4.82	4.85	4.85
query36	1.06	1.01	1.03
query37	0.06	0.05	0.05
query38	0.03	0.02	0.02
query39	0.02	0.01	0.01
query40	0.16	0.14	0.14
query41	0.07	0.01	0.01
query42	0.02	0.01	0.01
query43	0.02	0.02	0.02
Total cold run time: 103.74 s
Total hot run time: 31.23 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 95e593a59dbb14415e83a152fe7bb7fd5688fcb6 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.4 seconds inserted 10000000 Rows, about 467K ops/s

@bobhan1
Copy link
Contributor Author

bobhan1 commented Sep 21, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.79% (8141/21542)
Line Coverage: 29.54% (66980/226779)
Region Coverage: 29.02% (34556/119070)
Branch Coverage: 24.93% (17802/71406)
Coverage Report: http://coverage.selectdb-in.cc/coverage/fc4e6a58fefbf61358fdcf6c1dd499d7175aa073_fc4e6a58fefbf61358fdcf6c1dd499d7175aa073/report/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions left review comments

Assignees
No one assigned
Labels
kind/test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobhan1 @doris-robot