Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement](brpc)Added enable_brpc_builtin_services parameter in be.conf (#40718) #41047

Merged

Conversation

hubgeter
Copy link
Contributor

bp #40718

Proposed changes

Since brpc's built-in services will expose some internal server status, for security reasons, add the parameter enable_brpc_builtin_services in be.conf. When the parameter is false, this built-in service can be disabled.

….conf (apache#40718)

## Proposed changes

Since [brpc's built-in
services](https://brpc.apache.org/zh/docs/builtin-services/buildin_services/)
will expose some internal server status, for security reasons, add the
parameter `enable_brpc_builtin_services` in `be.conf`. When the
parameter is false, this built-in service can be disabled.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@hubgeter
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.19% (9336/25800)
Line Coverage: 27.72% (76659/276537)
Region Coverage: 26.52% (39397/148552)
Branch Coverage: 23.32% (20063/86042)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0e73f1c05d8f621866af2c6cacb0a5bd449d003f_0e73f1c05d8f621866af2c6cacb0a5bd449d003f/report/index.html

@yiguolei yiguolei merged commit c9d71cd into apache:branch-2.1 Sep 21, 2024
20 of 22 checks passed
@yiguolei yiguolei mentioned this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants