-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](load) disable num segments check in compatibility mode #41053
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
TPC-H: Total hot run time: 41662 ms
|
TPC-DS: Total hot run time: 195622 ms
|
ClickBench: Total hot run time: 32.9 s
|
TeamCity be ut coverage result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
Proposed changes
When using mixed version of BEs, sink v2 on old BE won't report num segments to load streams on the new BE.
This will cause false positive segment num mismatch.
This PR addressed this issue by disabling num segments check when any tablets_to_commit proto has not set num_segments field.