[Feature](topn) change topn_filter_limit_threshold to topn_filter_ratio #41066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run buildall |
|
run buildall |
|
run buildall |
englefly
reviewed
Sep 23, 2024
| @@ -1520,8 +1520,8 @@ public void setEnableLeftZigZag(boolean enableLeftZigZag) { | |||
| public boolean enableTwoPhaseReadOpt = true; | |||
| @VariableMgr.VarAttr(name = TOPN_OPT_LIMIT_THRESHOLD) | |||
| public long topnOptLimitThreshold = 1024; | |||
| @VariableMgr.VarAttr(name = TOPN_FILTER_LIMIT_THRESHOLD) | |||
| public long topnFilterLimitThreshold = 10240000; | |||
There was a problem hiding this comment.
topnFilterLimitThreshold is also used in PushTopnToAgg
There was a problem hiding this comment.
Now this parameter is divided into topnFilterLimitThreshold and topnOptLimitThreshold. topnFilterLimitThreshold only affects topn filter planning.
englefly
approved these changes
Sep 24, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
change topn_filter_limit_threshold to topn_filter_ratio