Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](cluster key) check short key index order in segment writer #41072

Merged
merged 2 commits into from
Sep 25, 2024
Merged

[fix](cluster key) check short key index order in segment writer #41072

merged 2 commits into from
Sep 25, 2024

Conversation

mymeiyi
Copy link
Contributor

@mymeiyi mymeiyi commented Sep 20, 2024

No description provided.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Sep 20, 2024

run buildall

@mymeiyi mymeiyi changed the title [fix](cluster key) check sorted by cluster key in segment writer [fix](cluster key) check short key index in segment writer Sep 20, 2024
@mymeiyi mymeiyi changed the title [fix](cluster key) check short key index in segment writer [fix](cluster key) check short key index order in segment writer Sep 20, 2024
@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.24% (9596/25769)
Line Coverage: 28.63% (79308/277047)
Region Coverage: 28.08% (41029/146106)
Branch Coverage: 24.71% (20899/84588)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2c278fe6e9f666b60ee19d68587f3ed9fd9ac774_2c278fe6e9f666b60ee19d68587f3ed9fd9ac774/report/index.html

dataroaring
dataroaring previously approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

zhannngchen
zhannngchen previously approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Sep 20, 2024

run p0

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Sep 20, 2024

run cloud_p0

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Sep 23, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.27% (9606/25774)
Line Coverage: 28.69% (79521/277186)
Region Coverage: 28.12% (41109/146181)
Branch Coverage: 24.77% (20956/84616)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9316170891b9985fb04c28f619ff67a772b25fe6_9316170891b9985fb04c28f619ff67a772b25fe6/report/index.html

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Sep 23, 2024
@mymeiyi
Copy link
Contributor Author

mymeiyi commented Sep 23, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.28% (9608/25775)
Line Coverage: 28.69% (79517/277193)
Region Coverage: 28.14% (41134/146189)
Branch Coverage: 24.77% (20962/84620)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3ec21f8f10f3fd400459c33cef4db0d900497be6_3ec21f8f10f3fd400459c33cef4db0d900497be6/report/index.html

dataroaring
dataroaring approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@mymeiyi mymeiyi mentioned this pull request Sep 24, 2024
Closed
@dataroaring dataroaring merged commit f146d90 into apache:master Sep 25, 2024
25 of 30 checks passed
dataroaring pushed a commit that referenced this pull request Oct 9, 2024
@mymeiyi @dataroaring
[fix](cluster key) check short key index order in segment writer (#41072
8fe3de2 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@Yukang-Lian Yukang-Lian Yukang-Lian approved these changes

@zhannngchen zhannngchen zhannngchen left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.3-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mymeiyi @doris-robot @zhannngchen @Yukang-Lian @dataroaring