Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](crash) be crash on DorisRAMCompoundDirectory::doDeleteFile #41722

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

cambyzju
Copy link
Contributor

@cambyzju cambyzju commented Oct 11, 2024

Issue Number: close #41721

When we open inverted_index_ram_dir_enable and close_on_error called, BE will crash:

doris::segment_v2::InvertedIndexColumnWriterImpl::close_on_error() 
  ==>lucene::index::IndexWriter::close(bool)
    ==>lucene::index::IndexWriter::closeInternal(bool) 
        ==>doris::segment_v2::DorisRAMCompoundDirectory::close() 
          ==>_CLDELETE(filesMap); (导致filesMap为null)
  ==>lucene::store::Directory::deleteFile(const char *, bool)
    ==>doris::segment_v2::DorisRAMCompoundDirectory::doDeleteFile(const char *)
      ==>filesMap->find((char*)name); (这里直接使用了filesMap导致空指针异常)

In branch 2.1, we already deleted the related codes in pr: #32418
image

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@cambyzju
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.82% (8149/21549)
Line Coverage: 29.55% (67083/226994)
Region Coverage: 29.02% (34578/119132)
Branch Coverage: 24.94% (17815/71444)
Coverage Report: http://coverage.selectdb-in.cc/coverage/18a29c7c71fb0ba8d151772e08d10fa0dd9d32cf_18a29c7c71fb0ba8d151772e08d10fa0dd9d32cf/report/index.html

@cambyzju
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.82% (8149/21549)
Line Coverage: 29.55% (67079/227001)
Region Coverage: 29.02% (34574/119139)
Branch Coverage: 24.93% (17814/71450)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b44289209e839c5b6786803d49d6968b9ff9fa8c_b44289209e839c5b6786803d49d6968b9ff9fa8c/report/index.html

Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lide-reed lide-reed merged commit 3518c7d into apache:branch-2.0 Oct 14, 2024
21 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants