Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](inverted index) Fix errors caused by enable_need_read_data_opt (#42064) #42362

Merged

Conversation

csun5285
Copy link
Contributor

Proposed changes

pick from master #42064

…pache#42064)

## Proposed changes

In the current backend implementation, it is not correctly handle counts
when `is null` predicate exists, so we forbid the storage layer's count
currently.

for example:
```
select count(b) from test where b is null 
```

When apply the is null filter, the result array will fill the default
value of the column type and the count operator can not detect whether
the result is null, so the count operator compute the wrong result.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@csun5285
Copy link
Contributor Author

run buildall

@csun5285
Copy link
Contributor Author

run buildall

@csun5285
Copy link
Contributor Author

run buildall

Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 24, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@airborne12 airborne12 merged commit ea07a39 into apache:branch-2.0 Oct 24, 2024
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/nereids kind/test reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants