Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](proto) upgrade protobuf to 21.11 #43035

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

morningman
Copy link
Contributor

@morningman morningman commented Oct 31, 2024

What problem does this PR solve?

Problem Summary:

Upgrade protoc to 21.11, to fix some cve

Check List (For Committer)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No colde files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.
  • Release note

    Bump protobuf version to 21.11

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morningman
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.86% (8159/21553)
Line Coverage: 29.57% (67141/227052)
Region Coverage: 29.05% (34629/119186)
Branch Coverage: 25.00% (17871/71492)
Coverage Report: http://coverage.selectdb-in.cc/coverage/896eb63292ff14a05d6c5ec85ddaaf3da825b967_896eb63292ff14a05d6c5ec85ddaaf3da825b967/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 50043 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 896eb63292ff14a05d6c5ec85ddaaf3da825b967, data reload: false

------ Round 1 ----------------------------------
q1	18698	4434	4402	4402
q2	2089	157	145	145
q3	10429	1922	1915	1915
q4	10310	1243	1336	1243
q5	8517	3959	3943	3943
q6	235	123	125	123
q7	2049	1658	1611	1611
q8	9531	2764	2742	2742
q9	10751	10557	10487	10487
q10	9004	3718	3536	3536
q11	419	245	255	245
q12	466	304	307	304
q13	18784	4009	4082	4009
q14	348	328	332	328
q15	513	468	455	455
q16	540	459	464	459
q17	1142	937	931	931
q18	7240	6811	6988	6811
q19	1672	1588	1576	1576
q20	536	334	310	310
q21	4421	4180	4076	4076
q22	486	392	402	392
Total cold run time: 118180 ms
Total hot run time: 50043 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4315	4317	4276	4276
q2	318	223	224	223
q3	4159	4150	4110	4110
q4	2746	2737	2759	2737
q5	7164	7154	7109	7109
q6	239	122	122	122
q7	3240	2829	2892	2829
q8	4387	4454	4521	4454
q9	14285	13778	14041	13778
q10	4243	4256	4273	4256
q11	747	701	673	673
q12	1045	859	843	843
q13	7029	3748	3763	3748
q14	464	417	424	417
q15	504	459	458	458
q16	636	596	589	589
q17	3835	3853	3872	3853
q18	8850	8879	8897	8879
q19	1690	1670	1643	1643
q20	2357	2152	2131	2131
q21	8482	8535	8520	8520
q22	1013	936	962	936
Total cold run time: 81748 ms
Total hot run time: 76584 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 212574 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 896eb63292ff14a05d6c5ec85ddaaf3da825b967, data reload: false

query1	967	389	418	389
query2	6574	2290	2089	2089
query3	6916	198	204	198
query4	23025	21513	21523	21513
query5	20078	6634	6580	6580
query6	280	220	255	220
query7	4327	305	313	305
query8	245	255	235	235
query9	3057	2651	2581	2581
query10	479	308	291	291
query11	15625	15154	14720	14720
query12	127	82	75	75
query13	1036	443	428	428
query14	17740	13736	13481	13481
query15	379	217	231	217
query16	6477	289	265	265
query17	1759	955	904	904
query18	897	322	310	310
query19	216	155	148	148
query20	98	98	95	95
query21	186	103	102	102
query22	5235	4918	4932	4918
query23	34145	33589	33501	33501
query24	7853	6317	6301	6301
query25	512	424	425	424
query26	1271	164	165	164
query27	2486	302	292	292
query28	6092	2228	2197	2197
query29	2793	2726	2800	2726
query30	236	169	164	164
query31	946	734	741	734
query32	71	64	60	60
query33	462	258	267	258
query34	874	472	473	472
query35	1155	970	930	930
query36	1247	1212	1224	1212
query37	174	63	61	61
query38	3031	2925	2991	2925
query39	1356	1335	1330	1330
query40	304	100	95	95
query41	39	41	37	37
query42	86	85	81	81
query43	678	616	602	602
query44	1150	728	717	717
query45	252	234	229	229
query46	1230	945	955	945
query47	1956	1726	1842	1726
query48	513	416	425	416
query49	648	381	384	381
query50	856	634	583	583
query51	4819	4679	4708	4679
query52	91	89	79	79
query53	224	177	188	177
query54	2664	2479	2465	2465
query55	92	71	84	71
query56	223	200	220	200
query57	1295	1163	1153	1153
query58	214	215	206	206
query59	3519	3242	3220	3220
query60	223	204	221	204
query61	103	95	100	95
query62	775	576	468	468
query63	198	174	175	174
query64	5838	1628	1382	1382
query65	3639	3564	3573	3564
query66	633	400	406	400
query67	16233	15347	15257	15257
query68	9219	631	640	631
query69	495	251	266	251
query70	1569	1372	1310	1310
query71	397	309	380	309
query72	6883	4912	4916	4912
query73	746	325	316	316
query74	6293	5822	5835	5822
query75	4751	3734	3725	3725
query76	4892	1156	1158	1156
query77	703	256	261	256
query78	12717	11740	12342	11740
query79	8600	638	633	633
query80	1515	399	382	382
query81	501	244	236	236
query82	1433	102	97	97
query83	173	134	132	132
query84	257	71	72	71
query85	911	317	323	317
query86	327	321	293	293
query87	3206	3026	3066	3026
query88	4507	2271	2266	2266
query89	438	276	288	276
query90	1972	210	217	210
query91	160	135	129	129
query92	62	54	51	51
query93	6041	593	564	564
query94	755	208	211	208
query95	2087	2000	2023	2000
query96	641	323	317	317
query97	6565	6400	6432	6400
query98	223	213	211	211
query99	2894	931	906	906
Total cold run time: 320855 ms
Total hot run time: 212574 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.11 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 896eb63292ff14a05d6c5ec85ddaaf3da825b967, data reload: false

query1	0.02	0.02	0.02
query2	0.08	0.02	0.02
query3	0.25	0.05	0.05
query4	1.80	0.07	0.07
query5	0.53	0.53	0.52
query6	1.23	0.61	0.60
query7	0.01	0.01	0.01
query8	0.04	0.02	0.02
query9	0.53	0.48	0.48
query10	0.53	0.52	0.52
query11	0.13	0.09	0.09
query12	0.12	0.10	0.09
query13	0.62	0.61	0.61
query14	0.80	0.78	0.80
query15	0.80	0.75	0.76
query16	0.39	0.37	0.37
query17	1.01	1.00	0.98
query18	0.24	0.25	0.26
query19	1.93	1.86	1.85
query20	0.02	0.01	0.02
query21	15.47	0.55	0.54
query22	2.17	2.54	1.71
query23	17.27	1.10	1.00
query24	5.90	1.44	1.12
query25	0.34	0.11	0.04
query26	0.72	0.16	0.15
query27	0.05	0.05	0.04
query28	6.70	0.75	0.73
query29	12.67	2.28	2.32
query30	0.57	0.53	0.58
query31	2.82	0.39	0.38
query32	3.35	0.51	0.49
query33	3.05	3.08	3.07
query34	15.26	4.84	4.79
query35	4.87	4.88	4.88
query36	1.04	1.01	1.03
query37	0.06	0.05	0.05
query38	0.04	0.02	0.02
query39	0.02	0.02	0.01
query40	0.16	0.14	0.14
query41	0.06	0.01	0.02
query42	0.02	0.01	0.02
query43	0.03	0.02	0.02
Total cold run time: 103.72 s
Total hot run time: 31.11 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 896eb63292ff14a05d6c5ec85ddaaf3da825b967 with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.8 seconds inserted 10000000 Rows, about 458K ops/s

@morningman morningman merged commit febedbb into apache:branch-2.0 Nov 1, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants