[fix](jni)fix jni defer deletelocalref #43594
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
This reverts commit 10fe743.
…and automatically generate dot (apache#42059)" This reverts commit b3b04ab.
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -18,101 +18,69 @@ | |||
| #include "http/action/jeprofile_actions.h" | |||
|
|
|||
| #include <jemalloc/jemalloc.h> | |||
| #include <stdlib.h> | |||
There was a problem hiding this comment.
warning: inclusion of deprecated C++ header 'stdlib.h'; consider using 'cstdlib' instead [modernize-deprecated-headers]
| #include <stdlib.h> | |
| #include <cstdlib> |
| class JeHeapAction : public HttpHandlerWithAuth { | ||
| public: | ||
| JeHeapAction(ExecEnv* exec_env) : HttpHandlerWithAuth(exec_env) {} | ||
| virtual ~JeHeapAction() = default; |
There was a problem hiding this comment.
warning: prefer using 'override' or (rarely) 'final' instead of 'virtual' [modernize-use-override]
| virtual ~JeHeapAction() = default; | |
| ~JeHeapAction() override = default; |
| } | ||
| } | ||
| } | ||
| virtual void handle(HttpRequest* req) override; |
There was a problem hiding this comment.
warning: 'virtual' is redundant since the function is already declared 'override' [modernize-use-override]
| virtual void handle(HttpRequest* req) override; | |
| void handle(HttpRequest* req) override; |
|
TeamCity be ut coverage result: |
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)