Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor](report) Simplify status reporter #43623

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[refactor](report) Simplify status reporter #43623

wants to merge 3 commits into from

Conversation

Gabriel39
Copy link
Contributor

@Gabriel39 Gabriel39 commented Nov 11, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

github-actions[bot]
github-actions bot reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/pipeline/pipeline_fragment_context.cpp
@@ -227,8 +235,7 @@ PipelinePtr PipelineFragmentContext::add_pipeline(PipelinePtr parent, int idx) {
return pipeline;
}

Status PipelineFragmentContext::prepare(const doris::TPipelineFragmentParams& request,
ThreadPool* thread_pool) {
Status PipelineFragmentContext::prepare(const doris::TPipelineFragmentParams& request) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: function 'prepare' exceeds recommended size/complexity thresholds [readability-function-size]

Status PipelineFragmentContext::prepare(const doris::TPipelineFragmentParams& request) {
                                ^
Additional context

be/src/pipeline/pipeline_fragment_context.cpp:237: 122 lines including whitespace and comments (threshold 80)

Status PipelineFragmentContext::prepare(const doris::TPipelineFragmentParams& request) {
                                ^

be/src/pipeline/pipeline_fragment_context.cpp
@@ -350,8 +359,8 @@
return Status::OK();
}

Status PipelineFragmentContext::_build_pipeline_tasks(const doris::TPipelineFragmentParams& request,
ThreadPool* thread_pool) {
Status PipelineFragmentContext::_build_pipeline_tasks(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: function '_build_pipeline_tasks' exceeds recommended size/complexity thresholds [readability-function-size]

Status PipelineFragmentContext::_build_pipeline_tasks(
                                ^
Additional context

be/src/pipeline/pipeline_fragment_context.cpp:361: 211 lines including whitespace and comments (threshold 80)

Status PipelineFragmentContext::_build_pipeline_tasks(
                                ^

be/src/pipeline/pipeline_fragment_context.cpp
// it is only invoked from the executor's reporting thread.
// Also, the reported status will always reflect the most recent execution status,
// including the final status when execution finishes.
void StatusReporter::_do_report(const ReportStatusRequest& req) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: function '_do_report' exceeds recommended size/complexity thresholds [readability-function-size]

void StatusReporter::_do_report(const ReportStatusRequest& req) {
                     ^
Additional context

be/src/pipeline/pipeline_fragment_context.cpp:1920: 153 lines including whitespace and comments (threshold 80)

void StatusReporter::_do_report(const ReportStatusRequest& req) {
                     ^

@Gabriel39
Copy link
Contributor Author

run buildall

@Gabriel39
Copy link
Contributor Author

run buildall

github-actions[bot]
github-actions bot reviewed Nov 12, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/pipeline/pipeline_fragment_context.cpp
@@ -227,8 +233,7 @@ PipelinePtr PipelineFragmentContext::add_pipeline(PipelinePtr parent, int idx) {
return pipeline;
}

Status PipelineFragmentContext::prepare(const doris::TPipelineFragmentParams& request,
ThreadPool* thread_pool) {
Status PipelineFragmentContext::prepare(const doris::TPipelineFragmentParams& request) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: function 'prepare' exceeds recommended size/complexity thresholds [readability-function-size]

Status PipelineFragmentContext::prepare(const doris::TPipelineFragmentParams& request) {
                                ^
Additional context

be/src/pipeline/pipeline_fragment_context.cpp:235: 124 lines including whitespace and comments (threshold 80)

Status PipelineFragmentContext::prepare(const doris::TPipelineFragmentParams& request) {
                                ^

github-actions[bot]
github-actions bot reviewed Nov 12, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/pipeline/pipeline_fragment_context.cpp
// it is only invoked from the executor's reporting thread.
// Also, the reported status will always reflect the most recent execution status,
// including the final status when execution finishes.
void StatusReporter::_do_report(const ReportStatusRequest& req) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: function '_do_report' exceeds recommended size/complexity thresholds [readability-function-size]

void StatusReporter::_do_report(const ReportStatusRequest& req) {
                     ^
Additional context

be/src/pipeline/pipeline_fragment_context.cpp:1913: 221 lines including whitespace and comments (threshold 80)

void StatusReporter::_do_report(const ReportStatusRequest& req) {
                     ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gabriel39 @doris-robot