Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor](rpc) Check client before RPC #43626

Merged
merged 3 commits into from
Nov 13, 2024
Merged

[minor](rpc) Check client before RPC #43626

merged 3 commits into from
Nov 13, 2024

Conversation

Gabriel39
Copy link
Contributor

@Gabriel39 Gabriel39 commented Nov 11, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Gabriel39
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

yiguolei
yiguolei previously approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@Gabriel39
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@yiguolei yiguolei added the p0_c label Nov 12, 2024
@Gabriel39
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 12, 2024
@Gabriel39 Gabriel39 merged commit 7988fed into apache:master Nov 13, 2024
29 of 32 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 13, 2024
@Gabriel39
[minor](rpc) Check client before RPC (#43626)
cf28505 
Check client before RPC
@github-actions github-actions bot mentioned this pull request Nov 13, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Nov 13, 2024
@Gabriel39
[minor](rpc) Check client before RPC (#43626)
84929c8 
Check client before RPC
@github-actions github-actions bot mentioned this pull request Nov 13, 2024
Merged
py023 pushed a commit to py023/doris that referenced this pull request Nov 13, 2024
@Gabriel39 @py023
[minor](rpc) Check client before RPC (apache#43626)
97a5fda 
Check client before RPC
yiguolei pushed a commit that referenced this pull request Nov 13, 2024
@github-actions @Gabriel39
branch-2.1: [minor](rpc) Check client before RPC (#43818)
47f842b 
Cherry-picked from #43626

Co-authored-by: Gabriel <[email protected]>
yiguolei pushed a commit that referenced this pull request Nov 13, 2024
@github-actions @Gabriel39
branch-3.0: [minor](rpc) Check client before RPC (#43816)
ca6b3e7 
Cherry-picked from #43626

Co-authored-by: Gabriel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiguolei yiguolei yiguolei approved these changes

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.3-merged p0_c reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gabriel39 @doris-robot @BiteTheDDDDt @yiguolei