Skip to content

[feature](analyzer) support * as json_object's parameter #57256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2025
Merged

[feature](analyzer) support * as json_object's parameter #57256

merged 1 commit into from
Oct 24, 2025

Conversation

@morrySnow
Copy link
Contributor

@morrySnow morrySnow commented Oct 23, 2025 •
edited
Loading

What problem does this PR solve?

Problem Summary:

support SQL as

SELECT json_object(*) FROM tbl

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Oct 23, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 38.71% (12/31) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 51.61% (16/31) 🎉
Increment coverage report
Complete coverage report

@morrySnow morrySnow force-pushed the support_json_object_star branch from 177ab3a to 1fb78e2 Compare October 23, 2025 08:00
@morrySnow
Copy link
Contributor Author

run buildall

@morrySnow morrySnow force-pushed the support_json_object_star branch from 1fb78e2 to 8696b0a Compare October 23, 2025 08:32
@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-DS: Total hot run time: 188476 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8696b0a3edcd8d3ad6366dc9e6c070121bce2b9e, data reload: false

query1	1063	448	409	409
query2	5702	1711	1697	1697
query3	5420	227	222	222
query4	26192	23664	23083	23083
query5	3893	650	486	486
query6	324	254	234	234
query7	3813	494	301	301
query8	302	273	284	273
query9	7084	2558	2574	2558
query10	515	343	291	291
query11	15861	15041	14984	14984
query12	186	115	114	114
query13	1604	551	435	435
query14	10070	9242	9221	9221
query15	220	211	189	189
query16	6025	738	519	519
query17	995	775	660	660
query18	2010	433	337	337
query19	221	214	181	181
query20	146	137	137	137
query21	233	139	118	118
query22	3998	4336	4052	4052
query23	34147	33134	33031	33031
query24	6417	2468	2461	2461
query25	603	512	448	448
query26	747	281	162	162
query27	2417	500	348	348
query28	4166	2220	2183	2183
query29	684	607	488	488
query30	301	226	269	226
query31	962	831	746	746
query32	88	78	77	77
query33	579	378	328	328
query34	824	862	517	517
query35	819	842	750	750
query36	949	1004	889	889
query37	133	113	90	90
query38	3640	3604	3486	3486
query39	1510	1420	1428	1420
query40	219	129	123	123
query41	75	61	63	61
query42	129	119	112	112
query43	484	493	470	470
query44	1228	755	742	742
query45	190	187	181	181
query46	904	998	647	647
query47	1761	1811	1749	1749
query48	400	430	336	336
query49	742	526	462	462
query50	658	699	412	412
query51	3979	3959	3875	3875
query52	116	110	109	109
query53	239	266	203	203
query54	622	595	531	531
query55	91	93	82	82
query56	325	354	313	313
query57	1195	1198	1152	1152
query58	293	287	311	287
query59	2588	2608	2611	2608
query60	347	350	329	329
query61	166	159	157	157
query62	815	723	673	673
query63	236	194	200	194
query64	3535	1156	891	891
query65	4046	3969	3997	3969
query66	1057	434	346	346
query67	15536	15203	14854	14854
query68	10622	949	605	605
query69	473	324	291	291
query70	1417	1253	1243	1243
query71	490	341	321	321
query72	6058	4955	4946	4946
query73	906	592	364	364
query74	9047	8898	8814	8814
query75	4326	3329	2783	2783
query76	3698	1212	720	720
query77	813	395	322	322
query78	9594	9889	8945	8945
query79	2349	798	600	600
query80	624	571	509	509
query81	523	273	237	237
query82	276	161	141	141
query83	278	278	246	246
query84	292	124	104	104
query85	904	469	427	427
query86	385	327	299	299
query87	3849	3683	3610	3610
query88	3674	2254	2212	2212
query89	407	325	296	296
query90	1823	223	226	223
query91	160	164	137	137
query92	84	70	68	68
query93	2187	959	648	648
query94	692	451	349	349
query95	420	326	312	312
query96	496	578	285	285
query97	2965	3007	2864	2864
query98	251	216	211	211
query99	1452	1408	1325	1325
Total cold run time: 268374 ms
Total hot run time: 188476 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.74 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8696b0a3edcd8d3ad6366dc9e6c070121bce2b9e, data reload: false

query1	0.06	0.06	0.05
query2	0.10	0.05	0.06
query3	0.25	0.08	0.08
query4	1.62	0.12	0.12
query5	0.28	0.27	0.25
query6	1.18	0.67	0.63
query7	0.03	0.03	0.03
query8	0.06	0.05	0.05
query9	0.62	0.53	0.53
query10	0.58	0.58	0.57
query11	0.17	0.14	0.11
query12	0.14	0.12	0.13
query13	0.63	0.60	0.60
query14	1.02	1.02	1.01
query15	0.86	0.84	0.87
query16	0.40	0.39	0.39
query17	1.03	1.01	1.02
query18	0.22	0.20	0.21
query19	1.94	1.82	1.80
query20	0.02	0.01	0.01
query21	15.46	0.18	0.14
query22	4.94	0.07	0.04
query23	15.69	0.26	0.11
query24	2.31	1.60	0.48
query25	0.09	0.06	0.06
query26	0.13	0.13	0.13
query27	0.07	0.06	0.06
query28	4.51	1.15	0.94
query29	12.56	3.99	3.28
query30	0.29	0.15	0.11
query31	2.83	0.58	0.38
query32	3.24	0.56	0.48
query33	3.09	3.10	3.13
query34	15.89	5.20	4.55
query35	4.56	4.58	4.66
query36	0.68	0.51	0.49
query37	0.11	0.07	0.07
query38	0.07	0.05	0.04
query39	0.04	0.02	0.03
query40	0.17	0.15	0.14
query41	0.08	0.03	0.03
query42	0.04	0.04	0.03
query43	0.04	0.04	0.03
Total cold run time: 98.1 s
Total hot run time: 27.74 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 23, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 81.25% (26/32) 🎉
Increment coverage report
Complete coverage report

@morrySnow morrySnow merged commit 4f00ca1 into apache:master Oct 24, 2025
29 of 30 checks passed
@morrySnow morrySnow deleted the support_json_object_star branch October 24, 2025 02:52
github-actions bot pushed a commit that referenced this pull request Oct 24, 2025
@morrySnow
[feature](analyzer) support * as json_object's parameter (#57256)
906a089 
support SQL as: SELECT json_object(*) FROM tbl
@github-actions github-actions bot mentioned this pull request Oct 24, 2025
Merged
yiguolei pushed a commit that referenced this pull request Oct 24, 2025
@github-actions @morrySnow
branch-4.0: [feature](analyzer) support * as json_object's parameter #…
d488737 
…57256 (#57288)

Cherry-picked from #57256

Co-authored-by: morrySnow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@924060929 924060929 924060929 approved these changes

@starocean999 starocean999 starocean999 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.1-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@morrySnow @Thearas @hello-stephen @doris-robot @924060929 @starocean999 @yiguolei