Skip to content

Conversation

@englefly
Copy link
Contributor

@englefly englefly commented Oct 23, 2025

What problem does this PR solve?

after extract common sub expression, some slots are not output slots any more. But if these slots are used in distribute expression list, wich is used by local shuffle, BE will report slot not found exception.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@englefly englefly marked this pull request as ready for review October 23, 2025 06:38
@englefly englefly marked this pull request as draft October 23, 2025 06:41
@englefly
Copy link
Contributor Author

run buildall

@englefly englefly marked this pull request as ready for review October 23, 2025 06:49
@englefly englefly changed the title Agg cse shufflekey [fix](nereids) adjust distribute expr lists after project common sub expression for aggregation Oct 23, 2025
@englefly
Copy link
Contributor Author

run buildall

1 similar comment
@englefly
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 56.25% (9/16) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

ClickBench: Total hot run time: 28.78 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 48fad2ad27ef4e08e69d537bd0ce42de898648c8, data reload: false

query1	0.07	0.05	0.05
query2	0.10	0.06	0.06
query3	0.25	0.09	0.09
query4	1.62	0.12	0.12
query5	0.28	0.27	0.28
query6	1.18	0.66	0.68
query7	0.04	0.03	0.02
query8	0.06	0.05	0.05
query9	0.63	0.56	0.54
query10	0.61	0.60	0.60
query11	0.18	0.12	0.12
query12	0.17	0.13	0.12
query13	0.63	0.62	0.60
query14	1.05	1.01	1.05
query15	0.88	0.90	0.87
query16	0.41	0.41	0.41
query17	1.12	1.10	1.20
query18	0.23	0.22	0.21
query19	2.04	1.84	1.88
query20	0.02	0.02	0.01
query21	15.36	0.19	0.13
query22	5.06	0.07	0.05
query23	15.66	0.29	0.12
query24	2.53	0.69	0.68
query25	0.08	0.07	0.06
query26	0.16	0.14	0.14
query27	0.08	0.06	0.06
query28	4.96	1.18	0.96
query29	12.66	4.29	3.55
query30	0.28	0.14	0.12
query31	2.83	0.62	0.41
query32	3.24	0.57	0.49
query33	3.18	3.21	3.12
query34	15.97	5.18	4.62
query35	4.66	4.63	4.60
query36	0.72	0.53	0.52
query37	0.11	0.08	0.08
query38	0.07	0.05	0.05
query39	0.04	0.03	0.04
query40	0.18	0.15	0.14
query41	0.10	0.03	0.03
query42	0.05	0.04	0.03
query43	0.05	0.04	0.04
Total cold run time: 99.6 s
Total hot run time: 28.78 s

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 93.75% (15/16) 🎉
Increment coverage report
Complete coverage report

@englefly
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

ClickBench: Total hot run time: 28.25 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3e53f1da3facd5896ddfc79853c0f1fc6c6bd67e, data reload: false

query1	0.06	0.05	0.04
query2	0.09	0.05	0.06
query3	0.25	0.08	0.08
query4	1.61	0.12	0.12
query5	0.28	0.26	0.25
query6	1.17	0.67	0.66
query7	0.04	0.03	0.03
query8	0.05	0.04	0.04
query9	0.63	0.55	0.53
query10	0.60	0.59	0.59
query11	0.17	0.12	0.12
query12	0.15	0.12	0.12
query13	0.62	0.61	0.61
query14	1.02	1.02	1.03
query15	0.86	0.86	0.89
query16	0.40	0.40	0.40
query17	1.05	1.04	1.06
query18	0.22	0.21	0.20
query19	1.94	1.81	1.91
query20	0.02	0.01	0.02
query21	15.44	0.19	0.13
query22	5.10	0.07	0.06
query23	15.69	0.28	0.10
query24	2.96	0.76	0.79
query25	0.09	0.07	0.06
query26	0.15	0.14	0.14
query27	0.06	0.06	0.05
query28	5.22	1.16	0.95
query29	12.57	4.02	3.29
query30	0.29	0.14	0.12
query31	2.83	0.64	0.39
query32	3.24	0.56	0.49
query33	3.06	3.13	3.07
query34	15.83	5.20	4.58
query35	4.65	4.62	4.60
query36	0.67	0.53	0.51
query37	0.10	0.08	0.07
query38	0.07	0.05	0.04
query39	0.04	0.02	0.03
query40	0.17	0.17	0.14
query41	0.08	0.04	0.04
query42	0.04	0.04	0.03
query43	0.04	0.04	0.03
Total cold run time: 99.62 s
Total hot run time: 28.25 s

@englefly
Copy link
Contributor Author

run vault_p0

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 95.00% (19/20) 🎉
Increment coverage report
Complete coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants