Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRILL-8180: Add Icons to Storage Plugin List #2507

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cgivre
Copy link
Contributor

@cgivre cgivre commented Mar 28, 2022

DRILL-8180: Add Icons to Storage Plugin List

Description

Documentation

This PR adds icons to the storage plugin list depending on the type of storage plugin. See screenshot below.

Screen Shot 2022-03-28 at 3 56 36 PM

The logo gets its name from the plugin config file. So a plugin FooStoragePluginConfig would be required to provide an icon of approx 40px x 40px called Foo.png.

Testing

Tested manually

@cgivre cgivre added the enhancement PRs that add a new functionality to Drill label Mar 28, 2022
@cgivre cgivre self-assigned this Mar 28, 2022
@jnturton jnturton requested a review from pjfanning March 29, 2022 08:57
@jnturton
Copy link
Contributor

Nice touch. I see we don't always have transparent backgrounds and sometimes we have a visible block behind the rendered icon. Let me know if I can help out here by hitting them with the GIMP.

@cgivre
Copy link
Contributor Author

cgivre commented Mar 29, 2022

Nice touch. I see we don't always have transparent backgrounds and sometimes we have a visible block behind the rendered icon. Let me know if I can help out here by hitting them with the GIMP.

I would really appreciate that. I don't actually have image editing software on my machine, or experience with the GIMP. Also, if you don't like any of the icons, feel free to change.

Copy link
Member

@vvysotskyi vvysotskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add plugin pictures to specific storage plugin folders instead of adding it to the java-exec module?

@cgivre
Copy link
Contributor Author

cgivre commented Mar 29, 2022

Is it possible to add plugin pictures to specific storage plugin folders instead of adding it to the java-exec module?

I suppose so, but I'm not quite sure how you would do that. All the Drill REST server components (to include static resources) are contained in java-exec. Any ideas?

@vvysotskyi
Copy link
Member

When running java application, resources from all places that are in class path should be accessible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement PRs that add a new functionality to Drill
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants