-
Notifications
You must be signed in to change notification settings - Fork 980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRILL-8180: Add Icons to Storage Plugin List #2507
base: master
Are you sure you want to change the base?
Conversation
Nice touch. I see we don't always have transparent backgrounds and sometimes we have a visible block behind the rendered icon. Let me know if I can help out here by hitting them with the GIMP. |
I would really appreciate that. I don't actually have image editing software on my machine, or experience with the GIMP. Also, if you don't like any of the icons, feel free to change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add plugin pictures to specific storage plugin folders instead of adding it to the java-exec module?
I suppose so, but I'm not quite sure how you would do that. All the Drill REST server components (to include static resources) are contained in |
When running java application, resources from all places that are in class path should be accessible. |
b5f2c24
to
0a208c0
Compare
DRILL-8180: Add Icons to Storage Plugin List
Description
Documentation
This PR adds icons to the storage plugin list depending on the type of storage plugin. See screenshot below.
The logo gets its name from the plugin config file. So a plugin
FooStoragePluginConfig
would be required to provide an icon of approx 40px x 40px calledFoo.png
.Testing
Tested manually