DRILL-8316: Convert Druid Storage Plugin to EVF & V2 JSON Reader #2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgivre
added
code-cleanup
refactoring
|
@Z0ltrix Would you mind reviewing this? The unit tests pass, but I'm not 100% certain this is handling large data sets correctly. |
|
@jnturton |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRILL-8316: Convert Druid Storage Plugin to EVF & V2 JSON Reader
Description
Converts the Druid storage plugin to use the V2 JSON reader. Also, updates the docker to test this plugin with the latest version of Druid.
Documentation
No user facing changes.
Testing
Ran existing unit tests.