DRILL-8506: Ignore JSON Elements with Empty Keys #2935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgivre
added
minor-update
backport-to-stable
|
Unless anyone has any objections, I'm going to merge this. It seems that whatever was going wrong with the CI has magically fixed itself. Although some unrelated Hive tests are failing due to connections being dropped, but only for Hadoop 2.... |
|
Hi @cgivre , thanks for adding this change! I really need it. I've noticed that this is not included in the docker versions yet (I mean, there isn't any release), do you know when I can run the docker image with your changes? |
|
@martingaleano we publish Docker images that track the Drill master branch. Anything tagged with "master" here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRILL-8506: Ignore JSON Elements with Empty Keys
Description
If Drill encounters a JSON field with an empty key, currently Drill throws an exception. This behavior prevents Drill from reading the rest of the data. This PR modifies Drill's behavior by simply ignoring JSON data with empty keys. Drill will generate a log warning message when this happens.
Documentation
No significant user facing changes.
Testing
Ran existing unit tests.