FLINK-31361 - Added the right shaded dependency for SQL client connector for kafka - Updated kafka.md #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the documentation on using the right dependency for 'properties.sasl.jaas.config'. When using 'flink-sql-connector-kafka.jar', existing document doesn't use the shaded dependency. Also added the name of the jar file (flink-sql-connector-kafka-x.xx.x.jar).
Update kafka.md - FLINK-31361 - Added the right shaded dependency for SQL client connector for kafka
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) |
alpinegizmo
requested changes
Mar 27, 2024
There was a problem hiding this comment.
@diptimanr Thank you for your contribution.
Aside from one small nit that I've suggested you fix, the basic content of the PR looks good. But would you please clean up the PR? In this case there should be just one commit, and more importantly, the commit message should be like this, with both the JIRA ticket and component clearly identified:
[FLINK-31361][docs] Added the right shaded dependency for SQL client connector for kafka
Also, please make the same change in the chinese language docs.
| @@ -674,7 +674,7 @@ Please note that the class path of the login module in `sasl.jaas.config` might | |||
| client dependencies, so you may need to rewrite it with the actual class path of the module in the JAR. | |||
| SQL client JAR has relocated Kafka client dependencies to `org.apache.flink.kafka.shaded.org.apache.kafka`, | |||
| then the path of plain login module in code snippets above need to be | |||
| `org.apache.flink.kafka.shaded.org.apache.kafka.common.security.plain.PlainLoginModule` when using SQL client JAR. | |||
| `org.apache.flink.kafka.shaded.org.apache.kafka.common.security.plain.PlainLoginModule` when using SQL client JAR(flink-sql-connector-kafka-x.xx.x.jar). | |||
There was a problem hiding this comment.
Suggested change
| `org.apache.flink.kafka.shaded.org.apache.kafka.common.security.plain.PlainLoginModule` when using SQL client JAR(flink-sql-connector-kafka-x.xx.x.jar). | |
| `org.apache.flink.kafka.shaded.org.apache.kafka.common.security.plain.PlainLoginModule` when using SQL client JAR (flink-sql-connector-kafka-x.xx.x.jar). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the documentation on using the right dependency for 'properties.sasl.jaas.config'. When using 'flink-sql-connector-kafka.jar', existing document doesn't use the shaded dependency.
Also added the name of the jar file (flink-sql-connector-kafka-x.xx.x.jar).