-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-34419][docker] Add tests for JDK 17 & 21 #182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching back to not-approved to discuss the matrix approach of your first commit. :)
Thanks @XComp, I'll ping you again once I update it |
2b537ed
to
dbebc4d
Compare
Morning @XComp, I have updated the PR accordingly. I had to set the I could change the test scripts to name containers so they don't clash. Please let me know. |
fail-fast: false | ||
max-parallel: 1 | ||
matrix: | ||
java_version: [ 8, 11, 17, 21 ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you separate the commit:
- [hotfix][ci] Updates actions
- [hotfix][ci] Utilize matrix strategy in GHA workflow
- [FLINK-34419][docker] Adds JDK17 and JDK21 support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed! I also changed accordingly other branches
dbebc4d
to
d760ccd
Compare
Another off-topic point, the tests build and package a job using |
1f08b25
to
3b9dc80
Compare
@XComp please have a look again. If this looks good, I will backport to other branches accordingly, thanks 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. 👍 Thanks. Can you please merge the parallelism hotfix commit into matrix hotfix commit? There's no reason to keep these two separate.
3b9dc80
to
cc33e95
Compare
Thanks @XComp for looking into 🙏 I have squashed it as you suggested, fixed. I will update the other PRs similar to this one tomorrow. Thanks a lot! |
Thanks @XComp, I have updated both pull requests |
[FLINK-34419]: Updated tests to use JDK 17 and 21 versions in
dev-master