[FLINK-32482][docker] Add Java 21 to build matrix and set default image to Java 17 #217
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
reswqa
commented
Mar 6, 2025
•
reswqa
commented
- Add jdk21 setup to build matrix.
- No longer building image for jdk8.
- Set default image tag to jdk17.
reswqa
changed the title
snuyanzin
reviewed
Mar 6, 2025
| @@ -59,7 +59,7 @@ fi | |||
|
|
|||
| # Defaults, can vary between versions | |||
| scala_versions=( 2.12 ) | |||
| java_versions=( 8 11 17 ) | |||
| java_versions=( 11 17 21 ) | |||
There was a problem hiding this comment.
is the same script used for 1.20.x?
if yes, then jdk8 still might be required for 1.20.2
Similar question about default
There was a problem hiding this comment.
No, this PR is for dev-master(This branch is intended for a new major release), and I will pick this to dev-2.0 then(for 2.0.0 rc1).
We should directly change dev-1.20 branch if we want do something for the old version(1.20).
snuyanzin
approved these changes
Mar 6, 2025
|
@snuyanzin The CI didn't pickup for jdk11 because we push nightly binary release to s3 with jdk17(Cannot run under jdk11 setup)... I think we should change it also to jdk11(apache/flink#26260). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.