[FLINK-33066] Support all k8s methods to configure env variable in operatorPod #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @dongwoo6kim. Please include the documentation in this change, unfortunately we maintain that manually here: |
dongwoo6kim
force-pushed
the
FLINK-33066
branch
from
fb77fef
to
9490081
Compare
|
Thanks @mbalassi. I have updated the docs |
srpraneeth
pushed a commit
to srpraneeth/flink-kubernetes-operator
that referenced
this pull request
Sep 14, 2023
…eratorPod (apache#671) Co-authored-by: dongwoo6.kim <[email protected]>
FabioWanner
pushed a commit
to FabioWanner/flink-kubernetes-operator
that referenced
this pull request
Nov 6, 2023
…eratorPod (apache#671) Co-authored-by: dongwoo6.kim <[email protected]> (cherry picked from commit 1053e26)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
To enhance Helm chart by adding full support for setting environment variables in values.yaml, including valueFrom and envFrom options, to align closely with native Kubernetes features and reduce user confusion.
Brief change log
Verifying this change
This change is a trivial work, locally checked the generation of manifest files.
Does this pull request potentially affect one of the following parts:
CustomResourceDescriptors: (yes / no)Documentation
Q) Should I open a new PR to document about
envFromfield if this PR is merged?