-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support config yaml #848
base: release-1.9
Are you sure you want to change the base?
Support config yaml #848
Conversation
I do think this would be better supported via a flag on configuration on FlinkDeployment, as it enables operator update independently from FlinkDeployments I am happy to make that change and would prefer that. Any thoughts? |
Hi, first of all, thank you for the contribution, but for better observability please try to always create a JIRA before opening a PR. |
Thanks @mateczagany for all the info! I have requested a JIRA account, and will file a ticket |
@mateczagany |
@@ -154,6 +154,9 @@ defaultConfiguration: | |||
# If set to false, loads just the overrides as in (2). | |||
# This option has not effect, if create is equal to false. | |||
append: true | |||
# If set to true, then will support YAML 1.2 syntax through use of `config.yaml` file. | |||
# If set to false, will make use of deprecated flink-conf.yaml filen. | |||
standardYaml: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great if this would be "automatic" based on whether the user specified flink-conf.yaml vs conf.yaml. Do you think that's possible?
@@ -83,7 +83,7 @@ under the License. | |||
<lombok.version>1.18.30</lombok.version> | |||
<commons-lang3.version>3.12.0</commons-lang3.version> | |||
<commons-io.version>2.11.0</commons-io.version> | |||
<flink.version>1.18.1</flink.version> | |||
<flink.version>1.19.0</flink.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also change the version to 1.19.1 as it was already released?
Support Flink 1.19 config.yaml configuration
Flink 1.19 introduced new config.yaml format. There are some dependencies on this new format in 1.19 that prevent old flink-conf.yaml from being able to configure properties.
This PR, adds support to be able to set a config.yaml file which is able to be consumed by the operator as well as deployments.
Brief change log
defaultConfiguration
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
CustomResourceDescriptors
: noDocumentation