Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36145] Rename flinkStateSnapshotReference to initialState #873

Closed
wants to merge 1 commit into from

Conversation

gyfora
Copy link
Contributor

@gyfora gyfora commented Aug 27, 2024

What is the purpose of the change

Rename JobSpec.flinkStateSnapshotReference to JobSpec.initialState. This should make less verbose and easier to memorize for users.

flinkStateSnapshotReference field has not been released officially yet, so this change should not affect production users.

Brief change log

  • Rename in Java, Markdown files and examples
  • Regenerate CRDs

Verifying this change

  • Unit tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changes to the CustomResourceDescriptors: yes
  • Core observer or reconciler logic that is regularly executed: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? updated

@gyfora gyfora requested a review from tweise August 27, 2024 14:42
@gyfora
Copy link
Contributor Author

gyfora commented Aug 27, 2024

Actually @tweise @mateczagany , I have a slight concern about this initialState reference field overall. It may make sense to simply keep the current initialSavepointPath field, because having a reference like field may allow users to "steal" the savepointpath of other users through the operator's permissions.

With the old way you either know the path or you don't.

@gyfora gyfora closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant