Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLINK-36332 Add option to select the Fabric8 httpclient implemention #881

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SamBarker
Copy link
Contributor

What is the purpose of the change

Enable the building of the operator using alternative Fabric8 http clients.

Brief change log

Enable the building of the operator using alternative Fabric8 http clients.

Verifying this change

This change is already covered by existing tests, such as (please describe tests).

The build should still work even when run with -Dfabric8.httpclinent.impl=vertx or jdk or jetty for that matter 😁

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): yes.
  • The public API, i.e., is any changes to the CustomResourceDescriptors: no
  • Core observer or reconciler logic that is regularly executed: no

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Comment on lines +437 to +441
<dependency>
<groupId>com.squareup.okhttp3</groupId>
<artifactId>okhttp</artifactId>
<version>${okhttp.version}</version>
</dependency>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default kubernetes-httpclient-okhttp pulls in OkHttp 3.X which is reported to have problems with Kubernetes IPV6 stacks e.g. https://issues.apache.org/jira/browse/FLINK-31928

@@ -110,6 +110,7 @@ under the License.
<surefire.module.config/>

<derby.version>10.15.2.0</derby.version>
<jetbrains.annotations.version>24.1.0</jetbrains.annotations.version>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required by KubernetesAutoScalerStateStore

@NotNull
@Override
public ConfigChanges getConfigChanges(KubernetesJobAutoScalerContext jobContext) {
return configMapStore
.getSerializedState(jobContext, CONFIG_OVERRIDES_KEY)
.map(KubernetesAutoScalerStateStore::deserializeConfigOverrides)
.orElse(new ConfigChanges());
}

though looking again that looks like a bug and it should use @nonnull instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant