FLINK-36551: [OLM] ensure that docker-entry.sh actually replaces the keystore pod volume #903
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request fixes a defect (FLINK-36551) in
tools/olm/docker_entry.sh
. In order for Flink Kubernetes Operator to function under OLM the webhook utilises a serving certificate provided by OLM. docker_entry.sh rewrites the deployment to allow this substitution to occur.Unfortunately,
docker_entry.sh
makes an assumption about the index of thekeystore
volume within the deployment. The index has changed over time, meaningdocker_entry.sh
replaces the wrong volume entry. This leads to a volume with a duplicate name. The CSV fails to be become ready as a result.Brief change log
keystore
volume within CSV.Verifying this change
I manually verified the change, firstly by ensuring the
yq
command was having the right effect and secondly by generating a OLM usinggenerate-olm-bundle.sh
.Does this pull request potentially affect one of the following parts:
CustomResourceDescriptors
: noDocumentation