Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLINK-36551: [OLM] ensure that docker-entry.sh actually replaces the keystore pod volume #903

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

k-wall
Copy link
Contributor

@k-wall k-wall commented Oct 16, 2024

What is the purpose of the change

This pull request fixes a defect (FLINK-36551) in tools/olm/docker_entry.sh. In order for Flink Kubernetes Operator to function under OLM the webhook utilises a serving certificate provided by OLM. docker_entry.sh rewrites the deployment to allow this substitution to occur.

Unfortunately, docker_entry.sh makes an assumption about the index of the keystore volume within the deployment. The index has changed over time, meaning docker_entry.sh replaces the wrong volume entry. This leads to a volume with a duplicate name. The CSV fails to be become ready as a result.

Brief change log

  • [OLM] Fix indexing error when replacing the keystore volume within CSV.

Verifying this change

I manually verified the change, firstly by ensuring the yq command was having the right effect and secondly by generating a OLM using generate-olm-bundle.sh.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changes to the CustomResourceDescriptors: no
  • Core observer or reconciler logic that is regularly executed: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

Copy link
Contributor

@SamBarker SamBarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I've replicated the original issues, as it leads to a failed install plan, and have verified this PR fixes it.

@gyfora gyfora merged commit 7390375 into apache:main Nov 4, 2024
233 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants