[hotfix] fix data race in drain() method in TaskMailboxImpl.java

apache · Feb 26, 2025 · 7e3700a · 7e3700a
1 parent 14a5375
commit 7e3700a
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/...ntime/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/TaskMailboxImpl.java b/...ntime/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/TaskMailboxImpl.java
@@ -243,11 +243,11 @@ private Mail takeOrNull(Deque<Mail> queue, int priority) {
 
     @Override
     public List<Mail> drain() {
-        List<Mail> drainedMails = new ArrayList<>(batch);
-        batch.clear();
         final ReentrantLock lock = this.lock;
         lock.lock();
         try {
+            List<Mail> drainedMails = new ArrayList<>(batch);
+            batch.clear();
             drainedMails.addAll(queue);
             queue.clear();
             hasNewMail = false;