[FLINK-37121][docs] Fix syntax and examples in create table statement doc #25982
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidradl
reviewed
Jan 14, 2025
| [ <distribution> ] | ||
| [PARTITIONED BY (partition_column_name1, partition_column_name2, ...)] |
There was a problem hiding this comment.
why has this line been moved?
There was a problem hiding this comment.
I try to parse a sql which DISTRIBUTION clause is after PARTITION clause will failed.And I checked create table in parserImpls.ftl. The DISTRIBUTION clause was defined before PARTITION clause.
davidradl
reviewed
Jan 14, 2025
| @@ -149,15 +149,15 @@ Flink SQL> INSERT INTO RubberOrders SELECT product, amount FROM Orders WHERE pro | |||
| ## CREATE TABLE | |||
|
|
|||
| ```text | |||
| CREATE TABLE [IF NOT EXISTS] [catalog_name.][db_name.]table_name | |||
| CREATE [TEMPORARY] TABLE [IF NOT EXISTS] [catalog_name.][db_name.]table_name | |||
There was a problem hiding this comment.
I guess we should include MATERIALIZED as well like this [TEMPORARY | MATERIALIZED ]
There was a problem hiding this comment.
CREATE MATERIALIZED TABLE statement cannot have column definitions, and MATERIALIZED TABLE has a separate page for description, so I think this page is to create a normal table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix syntax and examples in create table statement doc
Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation