[FLINK-37121][docs] Fix syntax and examples in create table statement doc #25982
Conversation
| [ <distribution> ] | ||
| [PARTITIONED BY (partition_column_name1, partition_column_name2, ...)] |
There was a problem hiding this comment.
why has this line been moved?
There was a problem hiding this comment.
I try to parse a sql which DISTRIBUTION clause is after PARTITION clause will failed.And I checked create table in parserImpls.ftl. The DISTRIBUTION clause was defined before PARTITION clause.
| @@ -149,15 +149,15 @@ Flink SQL> INSERT INTO RubberOrders SELECT product, amount FROM Orders WHERE pro | |||
| ## CREATE TABLE | |||
|
|
|||
| ```text | |||
| CREATE TABLE [IF NOT EXISTS] [catalog_name.][db_name.]table_name | |||
| CREATE [TEMPORARY] TABLE [IF NOT EXISTS] [catalog_name.][db_name.]table_name | |||
There was a problem hiding this comment.
I guess we should include MATERIALIZED as well like this [TEMPORARY | MATERIALIZED ]
There was a problem hiding this comment.
CREATE MATERIALIZED TABLE statement cannot have column definitions, and MATERIALIZED TABLE has a separate page for description, so I think this page is to create a normal table
There was a problem hiding this comment.
@jiefei30 that makes sense - though it is strange to have 2 create table grammars described. I suggest some text to link to the materialized table grammar would be useful. WDYT?
There was a problem hiding this comment.
@davidradl I agree. I will add some text to link to the materialized table grammar and temporary table description
|
@davidradl . I added some text to link to the materialized table grammar and temporary table description. I also built the docs on my mac and check the link are all right. |
What is the purpose of the change
Fix syntax and examples in create table statement doc
Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation