Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-37225] Remove remaining test resources of Gelly #26081

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

X-czh
Copy link
Contributor

@X-czh X-czh commented Jan 26, 2025

What is the purpose of the change

Remove remaining test resources of Gelly, which is removed from the codebase in FLINK-29668.

Brief change log

Remove remaining test resources of Gelly.

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 26, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@davidradl
Copy link
Contributor

I was looking to see when we decided that Gelly is no longer supported so should not be tested; I could not see anything in the Jira as to the history behind this.

@X-czh
Copy link
Contributor Author

X-czh commented Feb 8, 2025

@davidradl I'm not familiar with the background either, it was removed in Flink 1.16. @MartijnVisser Maybe you can provide more background here

@MartijnVisser
Copy link
Contributor

I was looking to see when we decided that Gelly is no longer supported so should not be tested; I could not see anything in the Jira as to the history behind this.

Decisions like this one to delete something, in this case Gelly, per https://flink.apache.org/how-to-contribute/contribute-code/#consensus should be discussed on the Dev mailing list.

See https://lists.apache.org/thread/kfwq87t5b79ndknndhodz6o8b0d8y41v for the discussion thread and https://lists.apache.org/thread/ng5t85t1lnmzrld4vvlk0mglq3fcgj50 for the result of the vote thread

@X-czh
Copy link
Contributor Author

X-czh commented Feb 25, 2025

@MartijnVisser Hi, if there's no other issues, would you mind helping to merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants