[FLINK-37383][flink-examples]Correct throttling logic on ThrottledIterator #26203
+197
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelzimmermann
changed the title
rafaelzimmermann
changed the title
rafaelzimmermann
force-pushed
the
fix-ThrottledIterator-last-batch-check-time-update
branch
from
8f82f6e to
600c9c2
Compare
Adding tests would require refactoring the time-dependent code, which might increase complexity for what's meant to be just an example class. Would you prefer to keep the implementation simple, or should I proceed with the refactoring? |
rafaelzimmermann
force-pushed
the
fix-ThrottledIterator-last-batch-check-time-update
branch
3 times, most recently
from
892cd0a to
3bf85ee
Compare
Tests added |
rafaelzimmermann
force-pushed
the
fix-ThrottledIterator-last-batch-check-time-update
branch
4 times, most recently
from
c1cfd9d to
f9edfd3
Compare
|
@flinkbot run azure |
rafaelzimmermann
force-pushed
the
fix-ThrottledIterator-last-batch-check-time-update
branch
2 times, most recently
from
a924f44 to
d772d70
Compare
The throttle function was updating its last batch check time before the sleep operation, causing it to underestimate the elapsed time and allow approximately double the intended throughput rate. Moving the timestamp update to after the sleep ensures the elapsed time calculation properly accounts for the full duration between batches, maintaining the configured rate limit. The commit refactors ThrottledIterator by: Adding injectable time supplier and sleep function for better testing Improving code maintainability with functional interfaces This change makes the code more testable and reliable while maintaining existing functionality. Add test coverage for ThrottledIterator edge cases Adds test coverage for invalid elements per second, consistent window size, and non-serializable source scenarios in ThrottledIterator tests.
rafaelzimmermann
force-pushed
the
fix-ThrottledIterator-last-batch-check-time-update
branch
from
d772d70 to
422a59d
Compare
|
@flinkbot run azure |
|
@davidradl The PR is ready for another review round. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The throttle function was updating its last batch check time before the sleep operation, causing it to underestimate the elapsed time and allow approximately double the intended throughput rate.
Brief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation