Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-37298] Added Pluggable Components for BatchStrategy & BufferWrapper in AsyncSinkWriter. #26274

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Poorvankbhatia
Copy link

What is the purpose of the change

FLIP-509

  • The current AsyncSinkWriter handles batching using fixed size constraints (maxBatchSize & maxBatchSizeInBytes). However, this approach lacks flexibility for more complex batching strategies like grouping records by partition key (important for sinks like Cassandra).
  • This change introduces a pluggable batching mechanism where sink implementers can define custom batching logic instead of relying on fixed queue-based buffering.
  • It also decouples the buffer implementation by replacing the direct use of Deque<RequestEntryWrapper> with a pluggable buffer wrapper, allowing for alternative data structures that optimize lookup, prioritization, or performance.

Brief change log

  • Added BufferWrapper interface to allow pluggable buffering strategies instead of a fixed Deque.
  • Implemented DequeBufferWrapper as the default buffer wrapper using ArrayDeque.
  • Introduced BatchCreator interface to enable custom batching logic.
  • Added SimpleBatchCreator as the default batch creator, replicating existing batch formation logic.
  • Created BatchCreationResult class to encapsulate batch metadata (entries, size, record count).
  • Modified AsyncSinkWriter to incorporate both the pluggable components.

Verifying this change

  • Added tests for BufferWrapper and its default implementation (DequeBufferWrapper).
  • Added tests for BatchCreator to validate the default batching behavior.
  • Ensured batched requests are correctly formed and processed using the new interfaces.
  • Verified that the default implementations (SimpleBatchCreator and DequeBufferWrapper) maintain existing behavior without requiring changes from users.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): yes
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? JavaDocs

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 8, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants