Skip to content

Conversation

twalthr
Copy link
Contributor

@twalthr twalthr commented Sep 18, 2025

What is the purpose of the change

For consistency reason, WatermarkPushDownSpec can be forward-compatible. While implementing this, I noticed that all sinks specs are forward compatible but not the source specs. This adds consistency. A general ignoring of unknown properties should be avoided, however, because this could lead to unintended side effects.

Brief change log

Add @JsonIgnoreProperties(ignoreUnknown = true) to all source specs

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 18, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@twalthr
Copy link
Contributor Author

twalthr commented Sep 19, 2025

@flinkbot run azure

@davidradl
Copy link
Contributor

@twalthr could we can add unit tests for these changes?

@twalthr
Copy link
Contributor Author

twalthr commented Sep 19, 2025

@davidradl this is not officially supported behavior. we don't claim forward compatibility at all. I just added it for code consistency.

@twalthr twalthr merged commit 933c9cf into apache:master Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants