[FLINK-38428][table] Support to run vector search with constant value #27130
Conversation
| .booleanType() | ||
| .defaultValue(false) | ||
| .withDescription( | ||
| "Whether to run an async search function or not. Default to false."); |
There was a problem hiding this comment.
I think this is ambiguous. Does it mean:
when false the function does not run or when false the function runs synchronously.
| .intType() | ||
| .defaultValue(10) | ||
| .withDescription( | ||
| "The max number of async i/o operation that the async vector search can trigger."); |
There was a problem hiding this comment.
nit: operation -> operations
| + "ALLOW_UNORDERED means the operator emits the result when " | ||
| + "execution finishes. The planner will attempt to use " | ||
| + "ALLOW_UNORDERED when it doesn't affect the correctness of " | ||
| + "the results.\n" |
There was a problem hiding this comment.
it would be useful to explain more about the situations where the the correctness of the results would have been effected, so we can understand the scenarios in which this option is ignored.
| GenericRowData argsData = new GenericRowData(args.length - 1); | ||
| for (int i = 1; i < args.length; ++i) { | ||
| argsData.setField(i, args[i]); | ||
| argsData.setField(i - 1, args[i]); |
There was a problem hiding this comment.
does this change mean that the previous code did not work? Is the symptom of this failure included in the Jira?
There was a problem hiding this comment.
We haven't added async vector search operator yet. 0.0
| RowType outputType = (RowType) getOutputType(); | ||
| StreamOperatorFactory<RowData> operatorFactory = | ||
| isAsyncEnabled | ||
| ? createAsyncVectorSearchOperator() |
There was a problem hiding this comment.
I am curious what this is doing , there is one implementation that throws an Exception. I thought this change is adding options for the async search.
There was a problem hiding this comment.
I will introduce async operator in another PR.
|
@davidradl Hi, please see the first PR #27122 |
github-actions
bot
added
the
community-reviewed
fsk119
force-pushed
the
literal-rule
branch
4 times, most recently
from
4944f99 to
42e6e02
Compare
|
@flinkbot run azure |
4 participants
What is the purpose of the change
Add a rule to convert vector search call with constant input to a correlated vector search call.
Brief change log
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation