[FLINK-39586][connector-base] Add watermark stall reproduction ITCase - #29049
Draft
MartijnVisser wants to merge 1 commit into
Draft
[FLINK-39586][connector-base] Add watermark stall reproduction ITCase#29049MartijnVisser wants to merge 1 commit into
MartijnVisser wants to merge 1 commit into
Conversation
After a HybridSource switches from a bounded to an unbounded source, a subtask that receives no splits from the unbounded source neither advances its watermark nor signals idleness, permanently capping the downstream combined watermark at the last bounded-era value. The ITCase pins the user-visible failure independent of any chosen fix semantics: it asserts only that the downstream watermark eventually passes the switch point. Generated-by: Claude Code (Fable 5)
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Reproduces FLINK-39586 end-to-end: after a
HybridSourceswitches from a bounded to an unbounded source, a subtask that receives no splits from the unbounded source neither advances its watermark nor signals idleness. Its last bounded-era watermark then permanently caps the downstream combined watermark (CombinedWatermarkStatus.updateCombinedWatermark()short-circuits on the empty output set without updating the idle flag).This is a reproduction PR and intentionally a draft: the new ITCase fails on master, so CI is expected to be red until a fix lands. The fix semantics (IDLE vs MAX_WATERMARK vs a dedicated FINISHED status, cf. FLINK-38477) are being discussed on the ticket and should be settled before a fix PR. The test only asserts user-visible behavior — the downstream watermark eventually passes the switch point — so it remains valid under any of those outcomes. A reference fix that makes it pass exists on branch
FLINK-39586of this fork.Two observations from building the reproduction:
idle=falsestate arose in the reported environment.advanceToEndOfEventTime, cf. FLINK-40499) never runs.Brief change log
HybridSourceWatermarkIdlenessITCase: a parallelism-2HybridSourcejob where the bounded phase assigns one split per subtask (per-split watermarks are emitted before the splits finish), the unbounded successor assigns its single split to subtask 0 with an enumerator that never signals no-more-splits (like a Kafka reader owning no partition), and a parallelism-1 sink observes the combined downstream watermark.Verifying this change
This change added tests and can be verified as follows:
FLINK-39586on this fork), the ITCase passes.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Fable 5)
🤖 Generated with Claude Code