[FLINK-40523][network] Compute tracePersist debug string only when trace logging is enabled - #29052
Open
1996fanrui wants to merge 1 commit into
Open
[FLINK-40523][network] Compute tracePersist debug string only when trace logging is enabled#290521996fanrui wants to merge 1 commit into
1996fanrui wants to merge 1 commit into
Conversation
…ace logging is enabled
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
NetworkActionsLogger.tracePersist(String, Buffer, ...)computedbuffer.toDebugString(INCLUDE_HASH)(a full buffer copy + hash + string allocation) before delegating to the trace-guarded overload, so
under backpressure this cost was paid for every persisted in-flight buffer even when TRACE was off.
This guards the computation behind
isTraceEnabled().Brief change log
toDebugStringcall inNetworkActionsLogger.tracePersist(...)withLOG.isTraceEnabled().Verifying this change
This change is a trivial rework / code cleanup without any test coverage. It is behavior-preserving:
the delegate overload already no-ops when TRACE is off; only the redundant debug-string computation is skipped.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?