Skip to content

[FLINK-40523][network] Compute tracePersist debug string only when trace logging is enabled - #29052

Open
1996fanrui wants to merge 1 commit into
apache:masterfrom
1996fanrui:FLINK-40523
Open

[FLINK-40523][network] Compute tracePersist debug string only when trace logging is enabled#29052
1996fanrui wants to merge 1 commit into
apache:masterfrom
1996fanrui:FLINK-40523

Conversation

@1996fanrui

@1996fanrui 1996fanrui commented Aug 31, 2026

Copy link
Copy Markdown
Member

What is the purpose of the change

NetworkActionsLogger.tracePersist(String, Buffer, ...) computed buffer.toDebugString(INCLUDE_HASH)
(a full buffer copy + hash + string allocation) before delegating to the trace-guarded overload, so
under backpressure this cost was paid for every persisted in-flight buffer even when TRACE was off.
This guards the computation behind isTraceEnabled().

Brief change log

  • [FLINK-40523] Guard the toDebugString call in NetworkActionsLogger.tracePersist(...) with LOG.isTraceEnabled().

Verifying this change

This change is a trivial rework / code cleanup without any test coverage. It is behavior-preserving:
the delegate overload already no-ops when TRACE is off; only the redundant debug-string computation is skipped.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): yes (removes redundant work on the checkpoint persist path when TRACE is off)
  • Anything that affects deployment or recovery: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

@flinkbot

flinkbot commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants