Repository navigation
Conversation
Timm0
marked this pull request as ready for review
October 28, 2026 16:27
Collaborator
- Add `JobRetrievalSupportedPipelineExecutor` to `flink-core`: a `PipelineExecutor` that returns a `JobClient` for a job it did not submit - Implement it in `AbstractSessionClusterExecutor`, so remote, YARN and Kubernetes session clusters support it
…refresh jobs - Add `RefreshJobTarget` (execution target and cluster id of a refresh job, with the checks for new and restarted jobs) and `RefreshJobResult` - Add `RefreshJobController`, which gets the status of, cancels and stops refresh jobs with a savepoint through the recorded target's `JobRetrievalSupportedPipelineExecutor` - Add `RefreshJobControllerTest` and `TestingJobClient`
- Add the `MaterializedTableExecutor`, `MaterializedTableExecutorFactory`, `MaterializedTableJobSubmitter` and `RefreshWorkflowContext` SPI - Move the SQL Gateway's `MaterializedTableManager` into the planner as `DefaultMaterializedTableExecutor`; `TableEnvironmentImpl` and the bridges look up its factory, also through the planner loader - Route `MaterializedTableOperation`s to the executor when the environment has a job submitter - Run the SQL Gateway's materialized table operations and REST refresh through the executor with `GatewayMaterializedTableJobSubmitter`; root causes are now `TableException`s - Replace `MaterializedTableManagerTest` with `DefaultMaterializedTableExecutorTest`
- Add `DefaultMaterializedTableJobSubmitter`, which submits refresh jobs from a plain `TableEnvironment` to session clusters - Route materialized table operations of every `TableEnvironment` to the executor - Add `MaterializedTableTableApiITCase`; `ExplainTest` writes its materialized tables to the catalog directly - Document Table API usage and fix `execution.mode` to `execution.target` in the deployment docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Materialized table refresh jobs could only be managed by the SQL Gateway, because
MaterializedTableManagerlived there. On a plainTableEnvironment,CREATE MATERIALIZED TABLEonly wrote the catalog without starting a refresh job,DROPleft the job running, andSUSPEND,RESUMEandREFRESHthrew. This change moves that logic into the planner asDefaultMaterializedTableExecutor, which everyTableEnvironmentuses, including the one inside the SQL Gateway.Brief change log
DefaultMaterializedTableExecutorreplacesMaterializedTableManagerandTableEnvironmentImpl#executeInternalroutes everyMaterializedTableOperationto itMaterializedTableJobSubmitterSPI:DefaultMaterializedTableJobSubmitterserves plain environmentsGatewayMaterializedTableJobSubmitterserves the SQL GatewayRefreshJobTargetverifies execution targetsJobRetrievalSupportedPipelineExecutor, implemented byAbstractSessionClusterExecutorMaterializedTableTableApiITCase, a Table API mirror ofMaterializedTableStatementITCaseDefaultMaterializedTableExecutorTest, which replacesMaterializedTableManagerTestRefreshJobControllerTestunit tests forRefreshJobControllerMaterializedTableExecutorFactorydiscovery check inLoaderITCaseVerifying this change
MaterializedTableTableApiITCase, a Table API mirror ofMaterializedTableStatementITCaseDefaultMaterializedTableExecutorTest, which replacesMaterializedTableManagerTestRefreshJobControllerTestunit tests forRefreshJobControllerMaterializedTableExecutorFactorydiscovery check inLoaderITCaseMaterializedTableStatementITCasereport green and show no behavior change for materialized tables from the SQL Gateway, apart from some exception typesDoes this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code Opus 5.5