fix(ci): Exit with subprocess return code in run_ci.py - #2560
Merged
Conversation
chaokunyang
approved these changes
Sep 1, 2025
* Use sys.exit() to propagate the return code from subprocess.call(). * This ensures that the CI pipeline correctly reflects the success or failure of the executed scripts. Fixes apache#2555
esafak
force-pushed
the
fix/2555-return_code
branch
from
September 2, 2025 00:56
12b63c7 to
92341ba
Compare
* Modify `setup.py` to include `cwd=project_dir` in `subprocess.check_call`. * This ensures that the bazel build command is executed in the project's root directory, preventing potential issues with relative path resolution.
Contributor
Author
|
You might want to revert c7a1a99 |
chaokunyang
force-pushed
the
fix/2555-return_code
branch
from
September 2, 2025 02:57
e8d0ce8 to
9654208
Compare
esafak
force-pushed
the
fix/2555-return_code
branch
from
September 2, 2025 04:02
dcffc42 to
f421ce0
Compare
* Introduce FunctionSerializer for proper serialization of functions and lambdas. * Update _registry.py to use FunctionSerializer for function types. * Modify test_serializer.py to reflect the new support for functions, ensuring they are no longer treated as unsupported. * Add tests in test_function.py to cover various scenarios of function serialization, including simple, complex, and nested functions. * Adjust error messages in _fory.py for clarity regarding unregistered types.
Contributor
Author
|
Can you fix the remaining graal error? |
Collaborator
I'm working on it, it's a little compilcated |
pandalee99
self-requested a review
September 2, 2025 07:28
pandalee99
approved these changes
Sep 2, 2025
chaokunyang
force-pushed
the
fix/2555-return_code
branch
from
September 2, 2025 07:53
2a35ecc to
cbc4897
Compare
chaokunyang
force-pushed
the
fix/2555-return_code
branch
from
September 2, 2025 07:55
cbc4897 to
7e452c2
Compare
chaokunyang
force-pushed
the
fix/2555-return_code
branch
from
September 2, 2025 14:43
7291e75 to
32ac097
Compare
chaokunyang
added a commit
to chaokunyang/fory
that referenced
this pull request
Sep 2, 2025
CI was not reflecting failures in shell script fallbacks (we are migrating to python) * Use sys.exit() to propagate the return code from subprocess.call(). * This ensures that the CI pipeline correctly reflects the success or failure of the executed scripts. You might want to merge apache#2561 first, to reduce the number of errors. --------- Co-authored-by: chaokunyang <shawn.ck.yang@gmail.com>
chaokunyang
added a commit
that referenced
this pull request
Sep 3, 2025
CI was not reflecting failures in shell script fallbacks (we are migrating to python) * Use sys.exit() to propagate the return code from subprocess.call(). * This ensures that the CI pipeline correctly reflects the success or failure of the executed scripts. You might want to merge #2561 first, to reduce the number of errors. --------- Co-authored-by: chaokunyang <shawn.ck.yang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
CI was not reflecting failures in shell script fallbacks (we are migrating to python)
What does this PR do?
Related issues
#2555
Notes
You might want to merge #2561 first, to reduce the number of errors.