fix(release): correct source and JVM artifacts - #3976
Merged
chaokunyang merged 3 commits intoAug 25, 2026
Conversation
pandalee99
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The
v1.7.0-rc2vote identified three release blockers:LICENSEdid not account for bundled third-party-derived source.META-INF/LICENSEandMETA-INF/NOTICE.The published RC2 artifacts were compared with tag
5f467b5c4721673eab6dc81fb365c74637c91d29before changing their owning build paths.What does this PR do?
java/LICENSEas the Java source distribution's top-level license, includingthird-party-derived source attribution, and completes
fory-core'scommons-lang3attribution.java/LICENSEwhen Apache's source-release descriptor lateradds a generated LICENSE with the same archive path. Generated
NOTICEandDEPENDENCIEScontinue to come from the Apache parent.
HEAD, thenremoves it after success or failure. The caller's build residue cannot enter the release.
directory before deploy reruns the lifecycle, and verifies the deployed build output again.
java/tree plus Maven'sgenerated legal files and its top-level
LICENSEto matchjava/LICENSEexactly.one
META-INF/LICENSEandMETA-INF/NOTICEin every public Kotlin Javadoc JAR.fory-json's Java 17 Ant execution, whose checked-insubtype table intentionally simulates processor output. This fixes the clean JDK 25 release
build exposed while rebuilding the artifacts.
Related issues
None.
Verification
mvn -B --no-transfer-progress -T10 clean package -DskipTests -Papache-releasepython ci/release.py verify_java_artifacts: passed before the final license-owner relocation;the source-release ZIP contained exactly 950 unique expected files, with no unexpected or missing
entries, and the same complete license content now stored at
java/LICENSE.mvn -B --no-transfer-progress clean package -DskipTests -Papache-releasepython ci/release.py verify_kotlin_artifacts: passed for all four public Kotlin artifacts; eachJavadoc JAR contained exactly one
META-INF/LICENSEandMETA-INF/NOTICE.python -m ruff format ci/release.py,python -m ruff check ci/release.py, andgit diff --check: passed.No build or test was run after relocating the already-inspected license content to
java/LICENSE,per contributor instruction. The final change affects only release-file ownership and packaging.
Does this PR introduce any user-facing change?
Benchmark
N/A. This PR changes release packaging and validation only.