Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEODE-9478: Fix status --dir to use file controller #6737

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

GEODE-9478: Fix status --dir to use file controller #6737

wants to merge 2 commits into from
+112 −256

Commits on Sep 29, 2022

  1. GEODE-9478: Fix status --dir to use file controller 

     - Previously when you only specified --dir option the PID was read from
   the member workDir and the status request was attempted to solved by
   using the attachment API, and after that JMX interface.
   But given only --dir was specified the controller resolving the
   request should be FileProcessController instead.
 - Logic has been changed for both servers and locators to always use
   FileProcessConroller whenever only --dir flag is specified.
 - Added an UT to verify new code.
 - Modified several ITs to verify the new behaviour.
 - Deleted the following ITs which no longer apply with the new logic:
   * statusWithEmptyPidFileThrowsIllegalArgumentException
   * statusWithEmptyWorkingDirectoryReturnsNotRespondingWithDetails
   * statusWithStalePidFileReturnsNotResponding
    @gaussianrecurrence
    gaussianrecurrence committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    ccb71a5 View commit details
    Browse the repository at this point in the history

  2. GEODE-9478: Revision 1 

     - Removed throws in javadoc given new constructors doesn't have any PID
    @gaussianrecurrence
    gaussianrecurrence committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    1ae64a5 View commit details
    Browse the repository at this point in the history