-
-
Notifications
You must be signed in to change notification settings - Fork 961
Run workflow with Java 24 instead of 23, in addition to LTS versions … #14732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…17 and 21 24 was released on March 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Java version in the GitHub workflows to run tests with Java 24 instead of Java 23, aligning with the release on March 18, 2025.
- Updated the matrix configuration for Java versions in two job definitions from [17, 21, 23] to [17, 21, 24].
- Adjusted the runner configuration for Ubuntu to ubuntu-24.04.
Comments suppressed due to low confidence (2)
.github/workflows/gradle.yml:63
- Ensure that the selected runner images (ubuntu-latest, windows-latest, macos-latest) support Java 24, as this update could affect build consistency across OS environments.
java: [ 17, 21, 24 ]
.github/workflows/gradle.yml:92
- Confirm that all jobs using Java 24 have the appropriate caching and dependency management configured to handle the new runtime version.
java: [ 17, 21, 24 ]
ac918c7
to
39e34bf
Compare
I don't think we can do this until Groovy supports Java 24. |
Does Groovy 4 even officially support Java 17?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests pass so let's do this!
Groovy is testing master with 24 and 25: But are not currently testing 24 on GROOVY_4_0_X: https://github.com/apache/groovy/blob/GROOVY_4_0_X/.github/workflows/groovy-build-test.yml#L56 I am following up to confirm Java 24 support and then will update this PR. |
Spring Boot is building with Java 24 against 3.5.x and 3.4.x: 3.5.x: https://github.com/spring-projects/spring-boot/blob/main/.github/workflows/ci.yml
https://docs.spring.io/spring-boot/system-requirements.html
https://docs.spring.io/spring-boot/3.5/system-requirements.html And Spring Framework 6.2.x will support JDK 17-25 (expected). https://github.com/spring-projects/spring-framework/wiki/Spring-Framework-Versions#jdk-version-range |
…17 and 21
24 was released on March 18, 2025