Skip to content

Run workflow with Java 24 instead of 23, in addition to LTS versions … #14732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025

Conversation

jamesfredley
Copy link
Contributor

…17 and 21

24 was released on March 18, 2025

@jamesfredley jamesfredley requested a review from Copilot May 13, 2025 15:27
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Java version in the GitHub workflows to run tests with Java 24 instead of Java 23, aligning with the release on March 18, 2025.

  • Updated the matrix configuration for Java versions in two job definitions from [17, 21, 23] to [17, 21, 24].
  • Adjusted the runner configuration for Ubuntu to ubuntu-24.04.
Comments suppressed due to low confidence (2)

.github/workflows/gradle.yml:63

  • Ensure that the selected runner images (ubuntu-latest, windows-latest, macos-latest) support Java 24, as this update could affect build consistency across OS environments.
java: [ 17, 21, 24 ]

.github/workflows/gradle.yml:92

  • Confirm that all jobs using Java 24 have the appropriate caching and dependency management configured to handle the new runtime version.
java: [ 17, 21, 24 ]

@jamesfredley jamesfredley force-pushed the github-workflow-java-24 branch from ac918c7 to 39e34bf Compare May 13, 2025 16:40
@jamesfredley jamesfredley self-assigned this May 13, 2025
@jamesfredley jamesfredley added this to the grails:7.0.0-M4 milestone May 13, 2025
@jamesfredley jamesfredley moved this to In Progress in Apache Grails 7.0.x May 13, 2025
@jamesfredley jamesfredley requested review from jdaugherty and matrei May 13, 2025 19:45
@jdaugherty
Copy link
Contributor

I don't think we can do this until Groovy supports Java 24.

@matrei
Copy link
Contributor

matrei commented May 14, 2025

I don't think we can do this until Groovy supports Java 24.

Does Groovy 4 even officially support Java 17?

Groovy 4.0 requires Java 8+ with support for up to Java 16.
https://groovy-lang.org/install.html

Copy link
Contributor

@matrei matrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests pass so let's do this!

@jamesfredley
Copy link
Contributor Author

Groovy is testing master with 24 and 25:
https://github.com/apache/groovy/blob/master/.github/workflows/groovy-build-test.yml#L58
https://github.com/apache/groovy/blob/master/.github/workflows/groovy-build-test.yml#L80

But are not currently testing 24 on GROOVY_4_0_X: https://github.com/apache/groovy/blob/GROOVY_4_0_X/.github/workflows/groovy-build-test.yml#L56

I am following up to confirm Java 24 support and then will update this PR.

@jamesfredley
Copy link
Contributor Author

Spring Boot is building with Java 24 against 3.5.x and 3.4.x:

3.5.x: https://github.com/spring-projects/spring-boot/blob/main/.github/workflows/ci.yml
3.4.x: https://github.com/spring-projects/spring-boot/blob/3.4.x/.github/workflows/ci.yml#L28

Spring Boot 3.4.5 requires at least Java 17 and is compatible with versions up to and including Java 24

https://docs.spring.io/spring-boot/system-requirements.html

Spring Boot 3.5.0-RC1 requires at least Java 17 and is compatible with versions up to and including Java 24.

https://docs.spring.io/spring-boot/3.5/system-requirements.html

And Spring Framework 6.2.x will support JDK 17-25 (expected). https://github.com/spring-projects/spring-framework/wiki/Spring-Framework-Versions#jdk-version-range

@jamesfredley jamesfredley merged commit e5627c9 into 7.0.x May 16, 2025
34 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Apache Grails 7.0.x May 16, 2025
@jamesfredley jamesfredley deleted the github-workflow-java-24 branch May 16, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants