-
-
Notifications
You must be signed in to change notification settings - Fork 966
Use consistent ISO-8601 formatting for rendering JSON Date, Calendar, LocalDateTime, and Instant properties #15121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a6bdba9
Consistent ISO-8601 JSON rendering of Date, LocalDateTime, and Instant
codeconsole f9451d1
Update grails-views-gson for consistent ISO-8601 rendering of Instant…
codeconsole 0232df3
Document upgrade path changes for ISO-8601 json dates
codeconsole f386bac
Fix Calendar to render ISO-8601 as well
codeconsole ee6b213
Add missing CalendarMarshaller
codeconsole bf49682
Display LocalDateTime as ISO-8601 without timezone (local time)
codeconsole 4b8cfed
OffsetDateTimeMarshaller and ZonedDateTimeMarshaller support
codeconsole ba51b1f
LocalDate support
codeconsole b0fb1f8
Update for nonasecond precision
codeconsole 9cb1a0f
Merge branch '7.0.x' into 7.0.x-json-dates
codeconsole File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70 changes: 70 additions & 0 deletions
70
...verters/src/main/groovy/org/grails/web/converters/marshaller/json/CalendarMarshaller.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.grails.web.converters.marshaller.json; | ||
|
|
||
| import java.text.Format; | ||
| import java.util.Calendar; | ||
| import java.util.Locale; | ||
| import java.util.TimeZone; | ||
|
|
||
| import org.apache.commons.lang3.time.FastDateFormat; | ||
|
|
||
| import grails.converters.JSON; | ||
| import org.grails.web.converters.exceptions.ConverterException; | ||
| import org.grails.web.converters.marshaller.ObjectMarshaller; | ||
| import org.grails.web.json.JSONException; | ||
|
|
||
| /** | ||
| * JSON ObjectMarshaller which converts a Calendar Object to ISO-8601 format with Z suffix. | ||
| * | ||
| * @since 7.0 | ||
| */ | ||
| public class CalendarMarshaller implements ObjectMarshaller<JSON> { | ||
|
|
||
| private final Format formatter; | ||
|
|
||
| /** | ||
| * Constructor with a custom formatter. | ||
| * @param formatter the formatter | ||
| */ | ||
| public CalendarMarshaller(Format formatter) { | ||
| this.formatter = formatter; | ||
| } | ||
|
|
||
| /** | ||
| * Default constructor. | ||
| */ | ||
| public CalendarMarshaller() { | ||
| this(FastDateFormat.getInstance("yyyy-MM-dd'T'HH:mm:ss.SSS'Z'", TimeZone.getTimeZone("GMT"), Locale.US)); | ||
| } | ||
|
|
||
| public boolean supports(Object object) { | ||
| return object instanceof Calendar; | ||
| } | ||
|
|
||
| public void marshalObject(Object object, JSON converter) throws ConverterException { | ||
| try { | ||
| Calendar calendar = (Calendar) object; | ||
| converter.getWriter().value(formatter.format(calendar.getTime())); | ||
| } | ||
| catch (JSONException e) { | ||
| throw new ConverterException(e); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 49 additions & 0 deletions
49
...nverters/src/main/groovy/org/grails/web/converters/marshaller/json/InstantMarshaller.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.grails.web.converters.marshaller.json; | ||
|
|
||
| import java.time.Instant; | ||
| import java.time.format.DateTimeFormatter; | ||
|
|
||
| import grails.converters.JSON; | ||
| import org.grails.web.converters.exceptions.ConverterException; | ||
| import org.grails.web.converters.marshaller.ObjectMarshaller; | ||
| import org.grails.web.json.JSONException; | ||
|
|
||
| /** | ||
| * JSON ObjectMarshaller which converts an Instant to ISO-8601 format with Z suffix. | ||
| * | ||
| * @since 7.0 | ||
| */ | ||
| public class InstantMarshaller implements ObjectMarshaller<JSON> { | ||
|
|
||
| public boolean supports(Object object) { | ||
| return object instanceof Instant; | ||
| } | ||
|
|
||
| public void marshalObject(Object object, JSON converter) throws ConverterException { | ||
| try { | ||
| Instant instant = (Instant) object; | ||
| converter.getWriter().value(DateTimeFormatter.ISO_INSTANT.format(instant)); | ||
| } | ||
| catch (JSONException e) { | ||
| throw new ConverterException(e); | ||
| } | ||
| } | ||
| } |
49 changes: 49 additions & 0 deletions
49
...erters/src/main/groovy/org/grails/web/converters/marshaller/json/LocalDateMarshaller.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.grails.web.converters.marshaller.json; | ||
|
|
||
| import java.time.LocalDate; | ||
| import java.time.format.DateTimeFormatter; | ||
|
|
||
| import grails.converters.JSON; | ||
| import org.grails.web.converters.exceptions.ConverterException; | ||
| import org.grails.web.converters.marshaller.ObjectMarshaller; | ||
| import org.grails.web.json.JSONException; | ||
|
|
||
| /** | ||
| * JSON ObjectMarshaller which converts a LocalDate to ISO-8601 date format (YYYY-MM-DD). | ||
| * | ||
| * @since 7.0 | ||
| */ | ||
| public class LocalDateMarshaller implements ObjectMarshaller<JSON> { | ||
|
|
||
| public boolean supports(Object object) { | ||
| return object instanceof LocalDate; | ||
| } | ||
|
|
||
| public void marshalObject(Object object, JSON converter) throws ConverterException { | ||
| try { | ||
| LocalDate localDate = (LocalDate) object; | ||
| converter.getWriter().value(DateTimeFormatter.ISO_LOCAL_DATE.format(localDate)); | ||
| } | ||
| catch (JSONException e) { | ||
| throw new ConverterException(e); | ||
| } | ||
| } | ||
| } |
49 changes: 49 additions & 0 deletions
49
...rs/src/main/groovy/org/grails/web/converters/marshaller/json/LocalDateTimeMarshaller.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.grails.web.converters.marshaller.json; | ||
|
|
||
| import java.time.LocalDateTime; | ||
| import java.time.format.DateTimeFormatter; | ||
|
|
||
| import grails.converters.JSON; | ||
| import org.grails.web.converters.exceptions.ConverterException; | ||
| import org.grails.web.converters.marshaller.ObjectMarshaller; | ||
| import org.grails.web.json.JSONException; | ||
|
|
||
| /** | ||
| * JSON ObjectMarshaller which converts a LocalDateTime to ISO-8601 format (without timezone). | ||
| * | ||
| * @since 7.0 | ||
| */ | ||
| public class LocalDateTimeMarshaller implements ObjectMarshaller<JSON> { | ||
|
|
||
| public boolean supports(Object object) { | ||
| return object instanceof LocalDateTime; | ||
| } | ||
|
|
||
| public void marshalObject(Object object, JSON converter) throws ConverterException { | ||
| try { | ||
| LocalDateTime localDateTime = (LocalDateTime) object; | ||
| converter.getWriter().value(DateTimeFormatter.ISO_LOCAL_DATE_TIME.format(localDateTime)); | ||
| } | ||
| catch (JSONException e) { | ||
| throw new ConverterException(e); | ||
| } | ||
| } | ||
| } |
49 changes: 49 additions & 0 deletions
49
...s/src/main/groovy/org/grails/web/converters/marshaller/json/OffsetDateTimeMarshaller.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.grails.web.converters.marshaller.json; | ||
|
|
||
| import java.time.OffsetDateTime; | ||
| import java.time.format.DateTimeFormatter; | ||
|
|
||
| import grails.converters.JSON; | ||
| import org.grails.web.converters.exceptions.ConverterException; | ||
| import org.grails.web.converters.marshaller.ObjectMarshaller; | ||
| import org.grails.web.json.JSONException; | ||
|
|
||
| /** | ||
| * JSON ObjectMarshaller which converts an OffsetDateTime to ISO-8601 format with timezone offset. | ||
| * | ||
| * @since 7.0 | ||
| */ | ||
| public class OffsetDateTimeMarshaller implements ObjectMarshaller<JSON> { | ||
|
|
||
| public boolean supports(Object object) { | ||
| return object instanceof OffsetDateTime; | ||
| } | ||
|
|
||
| public void marshalObject(Object object, JSON converter) throws ConverterException { | ||
| try { | ||
| OffsetDateTime offsetDateTime = (OffsetDateTime) object; | ||
| converter.getWriter().value(DateTimeFormatter.ISO_OFFSET_DATE_TIME.format(offsetDateTime)); | ||
| } | ||
| catch (JSONException e) { | ||
| throw new ConverterException(e); | ||
| } | ||
| } | ||
| } |
49 changes: 49 additions & 0 deletions
49
...rs/src/main/groovy/org/grails/web/converters/marshaller/json/ZonedDateTimeMarshaller.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.grails.web.converters.marshaller.json; | ||
|
|
||
| import java.time.ZonedDateTime; | ||
| import java.time.format.DateTimeFormatter; | ||
|
|
||
| import grails.converters.JSON; | ||
| import org.grails.web.converters.exceptions.ConverterException; | ||
| import org.grails.web.converters.marshaller.ObjectMarshaller; | ||
| import org.grails.web.json.JSONException; | ||
|
|
||
| /** | ||
| * JSON ObjectMarshaller which converts a ZonedDateTime to ISO-8601 format with timezone offset. | ||
| * | ||
| * @since 7.0 | ||
| */ | ||
| public class ZonedDateTimeMarshaller implements ObjectMarshaller<JSON> { | ||
|
|
||
| public boolean supports(Object object) { | ||
| return object instanceof ZonedDateTime; | ||
| } | ||
|
|
||
| public void marshalObject(Object object, JSON converter) throws ConverterException { | ||
| try { | ||
| ZonedDateTime zonedDateTime = (ZonedDateTime) object; | ||
| converter.getWriter().value(DateTimeFormatter.ISO_OFFSET_DATE_TIME.format(zonedDateTime)); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add comment why we are using There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @matrei see comment above |
||
| } | ||
| catch (JSONException e) { | ||
| throw new ConverterException(e); | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.