[#6474] improvement(storage): batch listing securable objects in RoleMetaService #6601
+642
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unknowntpo
force-pushed
the
refactor-batch-listSecurableObjects
branch
3 times, most recently
from
6dfb680 to
28b252a
Compare
jerqi
reviewed
Mar 7, 2025
| @@ -88,6 +88,22 @@ public static SecurableObject ofTable( | |||
| return of(MetadataObject.Type.TABLE, names, privileges); | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Column isn't the securable object. So you should remove this.
There was a problem hiding this comment.
@jerqi ok, done.
jerqi
reviewed
Mar 7, 2025
| @@ -120,6 +136,22 @@ public static SecurableObject ofFileset( | |||
| return of(MetadataObject.Type.FILESET, names, privileges); | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
We don't support the privilege of the model now. You can remove this temporaly.
…s: catalogIdAndNameMap
unknowntpo
force-pushed
the
refactor-batch-listSecurableObjects
branch
from
fb218a0 to
79de9f1
Compare
yuqi1129
reviewed
Mar 10, 2025
| * if no Metalake objects are found for the given IDs. {@code @example} value of metalake full | ||
| * name: "metalake1.catalog1.schema1.table1" | ||
| */ | ||
| public static Map<Long, String> getMetalakeObjectFullNames(List<Long> ids) { |
There was a problem hiding this comment.
The name getMetalakeObjectsFullName may be more proper.
|
|
||
| schemaPOs.forEach( | ||
| schemaPO -> { | ||
| if (schemaPO.getSchemaId() == null) { |
There was a problem hiding this comment.
When will the schemaId be null?
jerqi
reviewed
Mar 10, 2025
| @@ -125,6 +142,8 @@ public static String getMetadataObjectFullName(String type, long metadataObjectI | |||
| case SCHEMA: | |||
| SchemaPO schemaPO = SchemaMetaService.getInstance().getSchemaPOById(objectId); | |||
| if (schemaPO != null) { | |||
| // if fullName is null: | |||
There was a problem hiding this comment.
I can't the point. What's the meaning of the comment.
| * if no Catalog objects are found for the given IDs. {@code @example} value of catalog full | ||
| * name: "catalog1" | ||
| */ | ||
| public static Map<Long, String> getCatalogObjectFullNames(List<Long> ids) { |
There was a problem hiding this comment.
Is it possible to merge getCatalogObjectFullNames and getSchemaIdAndNameMap?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Batch retrieving securable objects for
metalake,catalog,schema,table,model,topic,fileset(fileset has been implemented at #6455).Why are the changes needed?
Improve performance when role is bounded to lots of
SecurableObjects.Fix: #6474
Does this PR introduce any user-facing change?
No.
How was this patch tested?
In
TestSecurableObjects.testAllTypeSecurableObjects.Related Issue and PR: #6238 #6455