Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6641] fix(core): Possible error in the equals method for collection #6644

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sunxiaojian
Copy link
Contributor

What changes were proposed in this pull request?

Possible error in the equals method for collection

Why are the changes needed?

Fix: #6641

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

N/A

@yuqi1129
Copy link
Contributor

@sunxiaojian , Can you please check all places in the project and fix them all, these two places are just examples.

@sunxiaojian
Copy link
Contributor Author

@sunxiaojian , Can you please check all places in the project and fix them all, these two places are just examples.

ok, I checked. I'll double-check again.

@yuqi1129
Copy link
Contributor

@sunxiaojian , Can you please check all places in the project and fix them all, these two places are just examples.

ok, I checked. I'll double-check again.

At least TableEntity should be in the change list.

@sunxiaojian
Copy link
Contributor Author

@sunxiaojian , Can you please check all places in the project and fix them all, these two places are just examples.

ok, I checked. I'll double-check again.

At least TableEntity should be in the change list.

fixed

Copy link
Contributor

@yuqi1129 yuqi1129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuqi1129
Copy link
Contributor

@jerqi Would you like to take a look?

@jerqi
Copy link
Contributor

jerqi commented Mar 10, 2025

Member

Actually I think this is weird that null equals to empty collection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug report] Possible error in the equals method for collection
3 participants