Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GROOVY-11568: try invokeMethod(Class,Object,Object[],boolean,boolean) #2158

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eric-milles
Copy link
Member

When MethodSelector#setMetaClassCallHandleIfNeeded links to MetaObjectProtocol#invokeMethod(Object,String,Object[]), the sender class is dropped.

@eric-milles eric-milles marked this pull request as draft March 21, 2025 20:04
@eric-milles eric-milles marked this pull request as ready for review March 24, 2025 00:45
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 90.38462% with 5 lines in your changes missing coverage. Please review.

Project coverage is 68.8649%. Comparing base (305693a) to head (39d6bd3).

Files with missing lines Patch % Lines
...java/org/codehaus/groovy/vmplugin/v8/Selector.java 66.6667% 2 Missing and 2 partials ⚠️
src/main/java/groovy/lang/MetaClassImpl.java 90.0000% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2158        +/-   ##
==================================================
+ Coverage     68.8555%   68.8649%   +0.0094%     
- Complexity      29501      29506         +5     
==================================================
  Files            1421       1421                
  Lines          113304     113319        +15     
  Branches        19593      19597         +4     
==================================================
+ Hits            78016      78037        +21     
+ Misses          28741      28733         -8     
- Partials         6547       6549         +2     
Files with missing lines Coverage Δ
...aus/groovy/runtime/metaclass/ClosureMetaClass.java 72.7915% <100.0000%> (+0.7067%) ⬆️
...vy/vmplugin/v8/IndyGuardsFiltersAndSignatures.java 91.8033% <100.0000%> (ø)
src/main/java/groovy/lang/MetaClassImpl.java 78.2080% <90.0000%> (+0.1159%) ⬆️
...java/org/codehaus/groovy/vmplugin/v8/Selector.java 82.1285% <66.6667%> (-0.2485%) ⬇️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants