GUACAMOLE-637: The $^ variable is non-portable and specific to GNU …

…Make. As otherwise POSIX-compliant platforms may not provide this variable, we shouldn't use it here.
apache · Jan 24, 2019 · b7761e9 · b7761e9
1 parent 789e388
commit b7761e9
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/README-unit-testing.md b/README-unit-testing.md
@@ -60,7 +60,7 @@ modified to contain a sections like the following:
     CLEANFILES = _generated_runner.c
 
     _generated_runner.c: $(test_myproj_SOURCES)
-    	$(AM_V_GEN) $(GEN_RUNNER) $^ > $@
+    	$(AM_V_GEN) $(GEN_RUNNER) $(test_myproj_SOURCES) > $@
 
     nodist_test_libguac_SOURCES = \
         _generated_runner.c

diff --git a/src/common/tests/Makefile.am b/src/common/tests/Makefile.am
@@ -60,7 +60,7 @@ GEN_RUNNER = $(top_srcdir)/util/generate-test-runner.pl
 CLEANFILES = _generated_runner.c
 
 _generated_runner.c: $(test_common_SOURCES)
-	$(AM_V_GEN) $(GEN_RUNNER) $^ > $@
+	$(AM_V_GEN) $(GEN_RUNNER) $(test_common_SOURCES) > $@
 
 nodist_test_common_SOURCES = \
     _generated_runner.c

diff --git a/src/libguac/tests/Makefile.am b/src/libguac/tests/Makefile.am
@@ -67,7 +67,7 @@ GEN_RUNNER = $(top_srcdir)/util/generate-test-runner.pl
 CLEANFILES = _generated_runner.c
 
 _generated_runner.c: $(test_libguac_SOURCES)
-	$(AM_V_GEN) $(GEN_RUNNER) $^ > $@
+	$(AM_V_GEN) $(GEN_RUNNER) $(test_libguac_SOURCES) > $@
 
 nodist_test_libguac_SOURCES = \
     _generated_runner.c