GUACAMOLE-288: Add support for multi-monitor connections. #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corentin-soriano
force-pushed
the
GUACAMOLE-288_multi_monitors
branch
from
78954b5 to
d829739
Compare
corentin-soriano
force-pushed
the
GUACAMOLE-288_multi_monitors
branch
5 times, most recently
from
8374544 to
683800f
Compare
corentin-soriano
force-pushed
the
GUACAMOLE-288_multi_monitors
branch
from
683800f to
62c8b1e
Compare
corentin-soriano
force-pushed
the
GUACAMOLE-288_multi_monitors
branch
from
62c8b1e to
4ee5e1b
Compare
neandrake
reviewed
Feb 21, 2025
src/protocols/rdp/channels/disp.c
Outdated
Comment on lines
218
to
223
| && width * monitors_count == guac_rdp_get_width(rdp_inst) | ||
| && height == guac_rdp_get_height(rdp_inst)) | ||
| return; |
There was a problem hiding this comment.
This makes the assumption that monitors are horizontally aligned and have the same resolution. Is that a constraint for this change? It's probably a common setup it would be nice to be flexible in its support.
There was a problem hiding this comment.
Yes, all monitors have the same dimensions and are aligned left to right (the left one is the primary).
I haven't looked to do this better yet but there is no limitation of FreeRDP.
corentin-soriano
force-pushed
the
GUACAMOLE-288_multi_monitors
branch
from
4ee5e1b to
ac08c95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows as is to add multiple monitors of the same dimensions in RDP protocol if the server supports it.
I haven't looked at the VNC part yet.
Work in progress on client side to display each monitor in separate windows.
POC:
