Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUACAMOLE-2035: Add start-up period to guacd health check in Dockerfile #577

Open
wants to merge 2 commits into
base: patch
Choose a base branch
from

Conversation

jeloneal
Copy link

Added start-period to docker healthcheck. Should fix containers being stuck in starting state for a long time causing issues with certain docker compose setups.

Without the start-period parameter the healthcheck seems to run only after the set interval of 5 minutes. This is way too long if you use the guacamole container within a stack and the depends_on condition "service_healthy". The deployment of the stack will abort.

Tested this fix on my own setup and it fixes the problem for me. Might be useful for others as well.

@necouchman
Copy link
Contributor

@jeloneal : Thanks for the contribution. In order to process this change you will need to get a Jira account and create a ticket, and then tag both the commit messages and the pull request with the Jira issue. Also, please update the commit messages and Jira issue with more descriptive - something along the lines of "Add start-up period to guacd health check in Dockerfile."

For a full list of contribution guidelines, please see the following site: https://guacamole.apache.org/open-source/.

@jeloneal jeloneal changed the title Update Dockerfile Add start-up period to guacd health check in Dockerfile Feb 24, 2025
@jeloneal jeloneal changed the title Add start-up period to guacd health check in Dockerfile GUACAMOLE-2035: Add start-up period to guacd health check in Dockerfile Feb 24, 2025
@jeloneal jeloneal force-pushed the docker-healthcheck-fix branch from b6ffa3e to 8af8a7f Compare February 24, 2025 17:35
@jeloneal
Copy link
Author

@necouchman thanks for the advice. I updated all elements you mentioned and created the according Jira issue.

@necouchman necouchman changed the base branch from main to patch February 24, 2025 17:55
@necouchman
Copy link
Contributor

Thanks @jeloneal - one more request, could you please re-base this against the patch branch instead of main - I think this qualifies as a patch/fix, and we'll get it merged into that branch.

@jeloneal
Copy link
Author

Thanks @jeloneal - one more request, could you please re-base this against the patch branch instead of main - I think this qualifies as a patch/fix, and we'll get it merged into that branch.

@necouchman looks like you already did that or do you mean I shall fork the patch branch first and add my change from there? I'm not an expert with GIthub yet :)

@necouchman
Copy link
Contributor

@jeloneal I changed the PR request, but, as you can see, it now has 21 commits instead of just the one that you pushed. You'll need to do a git rebase within your local branch, and then a force git push to forcibly update the remote branch with those changes. This should re-align things such that the code will match the PR.

necouchman and others added 2 commits February 25, 2025 07:02
Added start-period to docker healthcheck. Should fix containers being stuck in `starting` state for a long time causing issues with certain docker compose setups
@jeloneal jeloneal force-pushed the docker-healthcheck-fix branch from 8af8a7f to 8a996a0 Compare February 25, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants