YARN-11709. NodeManager should be shut down or blacklisted when it ca… #6960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ferdelyi for the change, seems good to me. |
|
💔 -1 overall
This message was automatically generated. |
zeekling
reviewed
Aug 7, 2024
| LOG.error("Unrecoverable issue occurred. Marking the node as unhealthy to prevent " | ||
| + "further containers to get scheduled on the node and cause application failures. " + | ||
| "Exit code from the container " + locId + "startLocalizer is : " + exitCode, e); | ||
| nmContext.getNodeStatusUpdater().reportException(e); |
There was a problem hiding this comment.
If we can execute container-executor, do we need to restart NodeManager?
There was a problem hiding this comment.
@zeekling thank you for looking into this change! Yes, when we hit an unrecoverable issue with the NM, the root cause needs to be fixed and the NM manually restarted. This way the RM will not schedule applications to the node while the issue is present. When we let the RM to place containers to the faulty NM, it can lead to application failures. E.g. by reaching maximum number of application attempts when the AM was scheduled to the same node twice.
There was a problem hiding this comment.
It would be nice if it could automatically recover when container-executor is ok.
There was a problem hiding this comment.
@zeekling thank you for your suggestion. To keep this change simple and easy to follow, I've filed your improvement idea under: YARN-11715
NodeManager should recover by itself once the container-executor can run program again
…nnot run program /var/lib/yarn-ce/bin/container-executor
|
💔 -1 overall
This message was automatically generated. |
ferdelyi
force-pushed
the
YARN-11709
branch
2 times, most recently
from
7031ee0 to
e6a1038
Compare
|
🎊 +1 overall
This message was automatically generated. |
…nnot run program /var/lib/yarn-ce/bin/container-executor
|
@zeekling and @K0K0V0K thank you for your feedback on this PR! May I request a review? I've added the unit test and opened the YARN-11715 Jira to improve the change further. |
|
🎊 +1 overall
This message was automatically generated. |
|
Thanks @ferdelyi LGTM |
KeeProMise
pushed a commit
to KeeProMise/hadoop
that referenced
this pull request
Sep 9, 2024
…cannot run program /var/lib/yarn-ce/bin/container-executor (apache#6960)
Hexiaoqiao
pushed a commit
to Hexiaoqiao/hadoop
that referenced
this pull request
Sep 12, 2024
…cannot run program /var/lib/yarn-ce/bin/container-executor (apache#6960)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nnot run program /var/lib/yarn-ce/bin/container-executor
Description of PR
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?