HADOOP-19165. Drop protobuf 2.5.0 from the distribution

[ayushtkn]

Description of PR

Drop protobuf 2.5.0 from the distribution, Hadoop uses the one from hadoop-thirdparty, we ideally don't need it.

How was this patch tested?

Manually

1. The contents of the distro:

Before:

ayushsaxena@ayushsaxena share % ls -l -R . | grep protobuf
-rw-r--r--@ 1 ayushsaxena  staff  1952718 Sep 18 10:54 hadoop-shaded-protobuf_3_25-1.3.0.jar       
-rw-r--r--@ 1 ayushsaxena  staff  1952718 Sep 18 10:56 hadoop-shaded-protobuf_3_25-1.3.0.jar
-rw-r--r--@ 1 ayushsaxena  staff     5105 Sep 18 10:16 grpc-protobuf-1.53.0.jar
-rw-r--r--@ 1 ayushsaxena  staff     7555 Sep 18 10:16 grpc-protobuf-lite-1.53.0.jar
-rw-r--r--@ 1 ayushsaxena  staff  1875927 Sep 18 10:16 hbase-shaded-protobuf-4.1.5.jar
-rw-r--r--@ 1 ayushsaxena  staff   533455 Sep 18 10:16 protobuf-java-2.5.0.jar

Now:

ayushsaxena@ayushsaxena share % ls -l -R . | grep protobuf                           
-rw-r--r--@ 1 ayushsaxena  staff  1952718 Sep 18 12:43 hadoop-shaded-protobuf_3_25-1.3.0.jar
-rw-r--r--@ 1 ayushsaxena  staff  1952718 Sep 18 12:44 hadoop-shaded-protobuf_3_25-1.3.0.jar
-rw-r--r--@ 1 ayushsaxena  staff     5105 Sep 18 12:48 grpc-protobuf-1.53.0.jar
-rw-r--r--@ 1 ayushsaxena  staff     7555 Sep 18 12:48 grpc-protobuf-lite-1.53.0.jar
-rw-r--r--@ 1 ayushsaxena  staff  1875927 Sep 18 12:48 hbase-shaded-protobuf-4.1.5.jar

No protbuf-java-2.5.0 now in the distro

2. Maven dependency:tree

Before:

ayushsaxena@ayushsaxena hadoop % mvn dependency:tree | grep protobuf-java:jar:2.5.0:compile    
[INFO] |  +- com.google.protobuf:protobuf-java:jar:2.5.0:compile
[INFO] |  +- com.google.protobuf:protobuf-java:jar:2.5.0:compile
[INFO] |  +- com.google.protobuf:protobuf-java:jar:2.5.0:compile
[INFO] |  |  +- com.google.protobuf:protobuf-java:jar:2.5.0:compile
ayushsaxena@ayushsaxena hadoop % 

Now:

ayushsaxena@ayushsaxena hadoop % mvn dependency:tree | grep protobuf-java:jar:2.5.0:compile 
ayushsaxena@ayushsaxena hadoop % 

Ran some UT selectively, Waiting for the CI to report any errors, if any

[INFO] --- surefire:3.0.0-M1:test (default-test) @ hadoop-yarn-server-timelineservice-hbase-tests ---
[WARNING] useSystemClassloader setting has no effect when not forking
[INFO] Running org.apache.hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesHBaseStorage
[INFO] Tests run: 34, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 26.743 s - in org.apache.hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesHBaseStorage
[INFO] Running org.apache.hadoop.yarn.server.timelineservice.storage.TestTimelineWriterHBaseDown
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 29.047 s - in org.apache.hadoop.yarn.server.timelineservice.storage.TestTimelineWriterHBaseDown
[INFO] Running org.apache.hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageApps
[INFO] Tests run: 20, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 20.154 s - in org.apache.hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageApps
[INFO] Running org.apache.hadoop.yarn.server.timelineservice.storage.TestTimelineReaderHBaseDown
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 176.944 s - in org.apache.hadoop.yarn.server.timelineservice.storage.TestTimelineReaderHBaseDown
[INFO] Running org.apache.hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageSchema
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 31.369 s - in org.apache.hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageSchema
[INFO] Running org.apache.hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageDomain
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.814 s - in org.apache.hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageDomain
[INFO] Running org.apache.hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageEntities
[INFO] Tests run: 20, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.688 s - in org.apache.hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageEntities
[INFO] Running org.apache.hadoop.yarn.server.timelineservice.storage.flow.TestHBaseStorageFlowActivity
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.037 s - in org.apache.hadoop.yarn.server.timelineservice.storage.flow.TestHBaseStorageFlowActivity
[INFO] Running org.apache.hadoop.yarn.server.timelineservice.storage.flow.TestHBaseStorageFlowRunCompaction
[INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 19.8 s - in org.apache.hadoop.yarn.server.timelineservice.storage.flow.TestHBaseStorageFlowRunCompaction
[INFO] Running org.apache.hadoop.yarn.server.timelineservice.storage.flow.TestHBaseStorageFlowRun
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 52.318 s - in org.apache.hadoop.yarn.server.timelineservice.storage.flow.TestHBaseStorageFlowRun
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 104, Failures: 0, Errors: 0, Skipped: 0
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------

++

[INFO] Reactor Summary for Apache Hadoop YARN TimelineService HBase Backend 3.5.0-SNAPSHOT:
[INFO] 
[INFO] Apache Hadoop YARN TimelineService HBase Backend ... SUCCESS [  0.415 s]
[INFO] Apache Hadoop YARN TimelineService HBase Common .... SUCCESS [  6.101 s]
[INFO] Apache Hadoop YARN TimelineService HBase Client .... SUCCESS [  4.537 s]
[INFO] Apache Hadoop YARN TimelineService HBase Servers ... SUCCESS [  0.033 s]
[INFO] Apache Hadoop YARN TimelineService HBase Server 2.5  SUCCESS [  0.206 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  11.838 s
[INFO] Finished at: 2024-09-18T14:37:25+05:30
[INFO] ------------------------------------------------------------------------
ayushsaxena@ayushsaxena hadoop-yarn-server-timelineservice-hbase % cd ..

For code changes:

• Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
• Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
• If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 20s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	32m 42s		trunk passed
+1 💚	compile	0m 17s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	compile	0m 16s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	mvnsite	0m 19s		trunk passed
+1 💚	javadoc	0m 20s		trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javadoc	0m 17s		trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	shadedclient	53m 47s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 10s		the patch passed
+1 💚	compile	0m 10s		the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javac	0m 10s		the patch passed
+1 💚	compile	0m 10s		the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	javac	0m 10s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 11s		the patch passed
+1 💚	javadoc	0m 10s		the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚	javadoc	0m 10s		the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚	shadedclient	20m 20s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 13s		hadoop-project in the patch passed.
+1 💚	asflicense	0m 25s		The patch does not generate ASF License warnings.
		76m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7051/1/artifact/out/Dockerfile
GITHUB PR	#7051
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname	Linux 400320336ae4 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 59c5539
Default Java	Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7051/1/testReport/
Max. process+thread count	561 (vs. ulimit of 5500)
modules	C: hadoop-project U: hadoop-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7051/1/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

[steveloughran]

Hasn't #6629 done this.

[ayushtkn]

Hbase-2 still declares protobuf-2.5.0, the original ticket has details
https://issues.apache.org/jira/browse/HADOOP-19107?focusedCommentId=17843349&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17843349

I couldn't figure out why HBase still defines it, but since you were mentioning to drop protobuf-2.5, so I thought of giving it a try if it doesn't break anything...